Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1060133002: Fix (nearly all) IWYU in fpdfskd/include/javascript/ headers. (Closed)

Created:
5 years, 8 months ago by Tom Sepez
Modified:
5 years, 8 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix (nearly all) IWYU in fpdfskd/include/javascript/ headers. Move some typedefs for v8 types into fxjs_v8.h wrapper to avoid circular inclusions. Also delete JS_Module.h, as no other file includes it. BUG=https://code.google.com/p/pdfium/issues/detail?id=66 R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/0415b381008dd0bcf2ed5da6f1371f1df396bc07

Patch Set 1 #

Total comments: 1

Patch Set 2 : Alphabetize nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -60 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/include/javascript/Consts.h View 1 chunk +2 lines, -0 lines 0 comments Download
M fpdfsdk/include/javascript/Document.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/javascript/Field.h View 1 chunk +5 lines, -0 lines 0 comments Download
M fpdfsdk/include/javascript/Icon.h View 1 chunk +3 lines, -4 lines 0 comments Download
M fpdfsdk/include/javascript/JS_Context.h View 1 chunk +4 lines, -0 lines 0 comments Download
M fpdfsdk/include/javascript/JS_Define.h View 1 chunk +0 lines, -4 lines 0 comments Download
M fpdfsdk/include/javascript/JS_EventHandler.h View 1 chunk +7 lines, -0 lines 0 comments Download
M fpdfsdk/include/javascript/JS_GlobalData.h View 2 chunks +3 lines, -2 lines 0 comments Download
D fpdfsdk/include/javascript/JS_Module.h View 1 chunk +0 lines, -47 lines 0 comments Download
M fpdfsdk/include/javascript/JS_Object.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/include/javascript/JS_Runtime.h View 1 chunk +7 lines, -0 lines 0 comments Download
M fpdfsdk/include/javascript/JS_Value.h View 1 chunk +3 lines, -0 lines 0 comments Download
M fpdfsdk/include/javascript/PublicMethods.h View 1 chunk +2 lines, -0 lines 0 comments Download
M fpdfsdk/include/javascript/app.h View 1 chunk +2 lines, -0 lines 0 comments Download
M fpdfsdk/include/javascript/color.h View 1 chunk +3 lines, -0 lines 0 comments Download
M fpdfsdk/include/javascript/console.h View 1 chunk +2 lines, -0 lines 0 comments Download
M fpdfsdk/include/javascript/event.h View 1 chunk +2 lines, -0 lines 0 comments Download
M fpdfsdk/include/javascript/global.h View 1 chunk +4 lines, -0 lines 0 comments Download
M fpdfsdk/include/javascript/report.h View 1 chunk +2 lines, -0 lines 0 comments Download
M fpdfsdk/include/javascript/util.h View 1 chunk +4 lines, -0 lines 0 comments Download
M fpdfsdk/include/jsapi/fxjs_v8.h View 1 chunk +7 lines, -0 lines 0 comments Download
M pdfium.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Tom Sepez
Lei, please review. This may unblock some other work. Thanks.
5 years, 8 months ago (2015-04-06 21:09:08 UTC) #1
Tom Sepez
Actually adding reviewer.
5 years, 8 months ago (2015-04-06 23:30:06 UTC) #3
Tom Sepez
5 years, 8 months ago (2015-04-07 19:14:02 UTC) #4
Lei Zhang
lgtm https://codereview.chromium.org/1060133002/diff/1/fpdfsdk/include/javascript/JS_Object.h File fpdfsdk/include/javascript/JS_Object.h (right): https://codereview.chromium.org/1060133002/diff/1/fpdfsdk/include/javascript/JS_Object.h#newcode10 fpdfsdk/include/javascript/JS_Object.h:10: #include "../jsapi/fxjs_v8.h" nit: alphabetical order
5 years, 8 months ago (2015-04-07 22:00:53 UTC) #5
Tom Sepez
5 years, 8 months ago (2015-04-07 22:27:04 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
0415b381008dd0bcf2ed5da6f1371f1df396bc07 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698