Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(671)

Issue 106503002: Let Node.textContent never throw (Closed)

Created:
7 years ago by philipj_slow
Modified:
7 years ago
CC:
blink-reviews, arv+blink, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, watchdog-blink-watchlist_google.com, Inactive
Visibility:
Public.

Description

Let Node.textContent never throw http://dom.spec.whatwg.org/#dom-node-textcontent This is per the spec. The only case where it could previously have thrown is if ContainerNode::checkAcceptChild returned false. I could not find a situation where that would have happened, so just assert that the internal appendChild call does not throw an exception. BUG=326133 TEST=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163275

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M Source/core/dom/Document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Node.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Node.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/Node.idl View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/html/HTMLOutputElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTextAreaElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/TextFieldInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
philipj_slow
7 years ago (2013-12-05 13:34:43 UTC) #1
jochen (gone - plz use gerrit)
lgtm
7 years ago (2013-12-05 14:23:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/106503002/1
7 years ago (2013-12-05 14:26:40 UTC) #3
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
7 years ago (2013-12-05 16:34:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/106503002/1
7 years ago (2013-12-05 16:46:05 UTC) #5
commit-bot: I haz the power
7 years ago (2013-12-05 16:46:23 UTC) #6
Message was sent while issue was closed.
Change committed as 163275

Powered by Google App Engine
This is Rietveld 408576698