Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1186)

Side by Side Diff: Source/core/dom/Document.cpp

Issue 106503002: Let Node.textContent never throw (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/dom/Node.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved. 8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
(...skipping 3963 matching lines...) Expand 10 before | Expand all | Expand 10 after
3974 // in the title bar. 3974 // in the title bar.
3975 if (m_titleElement 3975 if (m_titleElement
3976 && encoding() != newData.encoding 3976 && encoding() != newData.encoding
3977 && !m_titleElement->firstElementChild() 3977 && !m_titleElement->firstElementChild()
3978 && encoding() == Latin1Encoding() 3978 && encoding() == Latin1Encoding()
3979 && m_titleElement->textContent().containsOnlyLatin1()) { 3979 && m_titleElement->textContent().containsOnlyLatin1()) {
3980 3980
3981 CString originalBytes = m_titleElement->textContent().latin1(); 3981 CString originalBytes = m_titleElement->textContent().latin1();
3982 OwnPtr<TextCodec> codec = newTextCodec(newData.encoding); 3982 OwnPtr<TextCodec> codec = newTextCodec(newData.encoding);
3983 String correctlyDecodedTitle = codec->decode(originalBytes.data(), origi nalBytes.length(), true); 3983 String correctlyDecodedTitle = codec->decode(originalBytes.data(), origi nalBytes.length(), true);
3984 m_titleElement->setTextContent(correctlyDecodedTitle, IGNORE_EXCEPTION); 3984 m_titleElement->setTextContent(correctlyDecodedTitle);
3985 } 3985 }
3986 3986
3987 m_encodingData = newData; 3987 m_encodingData = newData;
3988 } 3988 }
3989 3989
3990 KURL Document::completeURL(const String& url, const KURL& baseURLOverride) const 3990 KURL Document::completeURL(const String& url, const KURL& baseURLOverride) const
3991 { 3991 {
3992 // Always return a null URL when passed a null string. 3992 // Always return a null URL when passed a null string.
3993 // FIXME: Should we change the KURL constructor to have this behavior? 3993 // FIXME: Should we change the KURL constructor to have this behavior?
3994 // See also [CSS]StyleSheet::completeURL(const String&) 3994 // See also [CSS]StyleSheet::completeURL(const String&)
(...skipping 1236 matching lines...) Expand 10 before | Expand all | Expand 10 after
5231 } 5231 }
5232 5232
5233 FastTextAutosizer* Document::fastTextAutosizer() 5233 FastTextAutosizer* Document::fastTextAutosizer()
5234 { 5234 {
5235 if (!m_fastTextAutosizer && RuntimeEnabledFeatures::fastTextAutosizingEnable d()) 5235 if (!m_fastTextAutosizer && RuntimeEnabledFeatures::fastTextAutosizingEnable d())
5236 m_fastTextAutosizer = FastTextAutosizer::create(this); 5236 m_fastTextAutosizer = FastTextAutosizer::create(this);
5237 return m_fastTextAutosizer.get(); 5237 return m_fastTextAutosizer.get();
5238 } 5238 }
5239 5239
5240 } // namespace WebCore 5240 } // namespace WebCore
OLDNEW
« no previous file with comments | « no previous file | Source/core/dom/Node.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698