Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 1064833002: [ia32] Match -0 - x with sign bit flip. (Closed)

Created:
5 years, 8 months ago by Benedikt Meurer
Modified:
5 years, 8 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ia32] Match -0 - x with sign bit flip. We can use xorps/xorpd on Intel CPUs to flip the sign bit. Ideally we'd use an absolute 128-bit constant in the code object, as OCaml/GCC does, however that requires 128-bit alignment for code objects, which is not yet implemented. So for now we materialize the mask inline. As drive-by-fix, don't hardcode xmm0 as scratch double register. R=svenpanne@chromium.org Committed: https://crrev.com/49bb6617aba36b1b346e2fbfefa2771de7234e68 Cr-Commit-Position: refs/heads/master@{#27618}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -27 lines) Patch
M src/compiler/ia32/code-generator-ia32.cc View 6 chunks +33 lines, -18 lines 0 comments Download
M src/compiler/ia32/instruction-codes-ia32.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 2 chunks +21 lines, -9 lines 0 comments Download
M test/unittests/compiler/ia32/instruction-selector-ia32-unittest.cc View 2 chunks +36 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 8 months ago (2015-04-07 09:35:45 UTC) #1
Benedikt Meurer
Hey Sven, This is a port of the x64 change landed earlier today (see https://codereview.chromium.org/1046893002). ...
5 years, 8 months ago (2015-04-07 09:37:09 UTC) #2
Sven Panne
lgtm
5 years, 8 months ago (2015-04-07 10:41:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1064833002/1
5 years, 8 months ago (2015-04-07 10:42:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-07 10:44:00 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 10:44:14 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/49bb6617aba36b1b346e2fbfefa2771de7234e68
Cr-Commit-Position: refs/heads/master@{#27618}

Powered by Google App Engine
This is Rietveld 408576698