Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 1046893002: [x64] Match -0 - x with sign bit flip. (Closed)

Created:
5 years, 8 months ago by Benedikt Meurer
Modified:
5 years, 8 months ago
Reviewers:
dcarney
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[x64] Match -0 - x with sign bit flip. We can use xorps/xorpd on Intel CPUs to flip the sign bit. Ideally we'd use a RIP-relative 128-bit constant in the code object, as OCaml/GCC does, however that requires 128-bit alignment for code objects, which is not yet implemented. So for now we materialize the mask inline. R=dcarney@chromium.org Committed: https://crrev.com/a1b2c275b7c821d7569d247463f74968695903b4 Cr-Commit-Position: refs/heads/master@{#27611}

Patch Set 1 #

Patch Set 2 : Unittest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -12 lines) Patch
M src/compiler/x64/code-generator-x64.cc View 2 chunks +19 lines, -3 lines 0 comments Download
M src/compiler/x64/instruction-codes-x64.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 2 chunks +21 lines, -9 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 chunk +40 lines, -0 lines 0 comments Download
M test/unittests/compiler/x64/instruction-selector-x64-unittest.cc View 1 3 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
5 years, 8 months ago (2015-03-30 11:32:24 UTC) #1
Benedikt Meurer
PTAL
5 years, 8 months ago (2015-03-30 11:32:48 UTC) #2
dcarney
lgtm
5 years, 8 months ago (2015-03-30 11:38:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1046893002/20001
5 years, 8 months ago (2015-04-07 07:13:58 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-07 07:35:01 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 07:35:19 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a1b2c275b7c821d7569d247463f74968695903b4
Cr-Commit-Position: refs/heads/master@{#27611}

Powered by Google App Engine
This is Rietveld 408576698