Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(831)

Unified Diff: components/favicon/core/favicon_handler.h

Issue 1064823002: Componentize FaviconTabHelper (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@favicon-notification
Patch Set: Fix BUILD.gn Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/favicon/core/favicon_driver_impl.cc ('k') | components/favicon/core/favicon_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/favicon/core/favicon_handler.h
diff --git a/components/favicon/core/favicon_handler.h b/components/favicon/core/favicon_handler.h
index 960eba5136c46ac3d052f173e831aa42a318d124..d8fee10bf7b78767abe76b5fae2ea0d7cf16998a 100644
--- a/components/favicon/core/favicon_handler.h
+++ b/components/favicon/core/favicon_handler.h
@@ -19,7 +19,6 @@
#include "ui/gfx/image/image.h"
#include "url/gurl.h"
-class FaviconTabHelperTest;
class SkBitmap;
class TestFaviconHandler;
@@ -118,6 +117,10 @@ class FaviconHandler {
return image_urls_;
}
+ // Returns whether the handler is waiting for a download to complete or for
+ // data from the FaviconService. Reserved for testing.
+ bool HasPendingTasksForTest();
+
protected:
// These virtual methods make FaviconHandler testable and are overridden by
// TestFaviconHandler.
@@ -155,7 +158,6 @@ class FaviconHandler {
private:
// For testing:
- friend class ::FaviconTabHelperTest;
friend class ::TestFaviconHandler;
// Represents an in progress download of an image from the renderer.
« no previous file with comments | « components/favicon/core/favicon_driver_impl.cc ('k') | components/favicon/core/favicon_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698