components/favicon/core/favicon_handler.cc - Issue 1064823002: Componentize FaviconTabHelper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/favicon/core/favicon_handler.cc

Issue 1064823002: Componentize FaviconTabHelper (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@favicon-notification

Patch Set: Fix BUILD.gn Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/favicon/core/favicon_handler.cc

diff --git a/components/favicon/core/favicon_handler.cc b/components/favicon/core/favicon_handler.cc

index adc0a5c4d721ecb7370b6b915af68a887d945c6e..aff16261e47917a0680e7ec581d1644f29875f1f 100644

--- a/components/favicon/core/favicon_handler.cc

+++ b/components/favicon/core/favicon_handler.cc

@@ -450,6 +450,11 @@ void FaviconHandler::OnDidDownloadFavicon(

}

+bool FaviconHandler::HasPendingTasksForTest() {

+ return !download_requests_.empty() ||

+ cancelable_task_tracker_.HasTrackedTasks();

bool FaviconHandler::PageChangedSinceFaviconWasRequested() {

if (UrlMatches(driver_->GetActiveURL(), url_) && url_.is_valid()) {

return false;