Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1064713005: collect phantom handle data before it gets overwritten (Closed)

Created:
5 years, 8 months ago by dcarney
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

collect phantom handle data before it gets overwritten R=jochen@chromium.org, hpayer@chromium.org, erikcorry@chromium.org BUG= Committed: https://crrev.com/b0f3074b36a0a2ac5f020c355762e83de4bb4e9c Cr-Commit-Position: refs/heads/master@{#27786}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -84 lines) Patch
M src/global-handles.h View 1 chunk +0 lines, -8 lines 0 comments Download
M src/global-handles.cc View 1 5 chunks +35 lines, -66 lines 2 comments Download
M src/heap/heap.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/heap/mark-compact.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
dcarney
ptal
5 years, 8 months ago (2015-04-13 11:08:01 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 8 months ago (2015-04-13 11:32:29 UTC) #3
Hannes Payer (out of office)
lgtm, one nit https://codereview.chromium.org/1064713005/diff/20001/src/global-handles.cc File src/global-handles.cc (right): https://codereview.chromium.org/1064713005/diff/20001/src/global-handles.cc#newcode174 src/global-handles.cc:174: !(state() == NEAR_DEATH && weakness_type() != ...
5 years, 8 months ago (2015-04-13 11:50:45 UTC) #4
dcarney
https://codereview.chromium.org/1064713005/diff/20001/src/global-handles.cc File src/global-handles.cc (right): https://codereview.chromium.org/1064713005/diff/20001/src/global-handles.cc#newcode174 src/global-handles.cc:174: !(state() == NEAR_DEATH && weakness_type() != NORMAL_WEAK); On 2015/04/13 ...
5 years, 8 months ago (2015-04-13 12:27:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1064713005/20001
5 years, 8 months ago (2015-04-13 13:13:45 UTC) #7
dcarney
On 2015/04/13 13:13:45, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
5 years, 8 months ago (2015-04-13 13:14:43 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-13 13:15:25 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-13 13:15:39 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/b0f3074b36a0a2ac5f020c355762e83de4bb4e9c
Cr-Commit-Position: refs/heads/master@{#27786}

Powered by Google App Engine
This is Rietveld 408576698