Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Unified Diff: src/heap/heap.cc

Issue 1064713005: collect phantom handle data before it gets overwritten (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/heap/heap.cc
diff --git a/src/heap/heap.cc b/src/heap/heap.cc
index 418cad72be73f8598690cc42e56edc7368d405e2..b911ad1ee68006ba6358f33c4f4c50996f4b094b 100644
--- a/src/heap/heap.cc
+++ b/src/heap/heap.cc
@@ -1573,11 +1573,6 @@ void Heap::Scavenge() {
ScavengeWeakObjectRetainer weak_object_retainer(this);
ProcessYoungWeakReferences(&weak_object_retainer);
- // Collects callback info for handles referenced by young generation that are
- // pending (about to be collected) and either phantom or internal-fields.
- // Releases the global handles. See also PostGarbageCollectionProcessing.
- isolate()->global_handles()->CollectYoungPhantomCallbackData();
-
DCHECK(new_space_front == new_space_.top());
// Set age mark.
« src/global-handles.cc ('K') | « src/global-handles.cc ('k') | src/heap/mark-compact.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698