media/video/capture/video_capture_device.h - Issue 1064703002: VideoCaptureBufferPool: Refactor to allow support of non-ShMem backed buffers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/video/capture/video_capture_device.h

Issue 1064703002: VideoCaptureBufferPool: Refactor to allow support of non-ShMem backed buffers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/media/video_capture_texture_wrapper.cc ('K') | « media/video/capture/fake_video_capture_device_unittest.cc ('k') | media/video/capture/video_capture_device_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/video/capture/video_capture_device.h

diff --git a/media/video/capture/video_capture_device.h b/media/video/capture/video_capture_device.h

index fe7756f738ac743a3e7f5511e32e9e4042657370..e1e9c14e819192f79a848ec822688e49783cb6d2 100644

--- a/media/video/capture/video_capture_device.h

+++ b/media/video/capture/video_capture_device.h

@@ -245,8 +245,7 @@ class MEDIA_EXPORT VideoCaptureDevice {

// The output buffer stays reserved for use until the Buffer object is

// destroyed.

virtual scoped_refptr<Buffer> ReserveOutputBuffer(

- media::VideoFrame::Format format,

- const gfx::Size& dimensions) = 0;

+ const VideoCaptureFormat& format) = 0;

miu 2015/04/08 01:20:03 Seems like this interface change is unnecsessary a

mcasas 2015/04/08 22:07:06 No reason to bundle them but I changed the first p

// Captured a new video frame, held in |frame|.