VideoCaptureBufferPool: Refactor to allow support of non-ShMem backed buffers

media/video/capture/video_capture_device.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // VideoCaptureDevice is the abstract base class for realizing video capture
 // device support in Chromium. It provides the interface for OS dependent
 // implementations.
 // The class is created and functions are invoked on a thread owned by
 // VideoCaptureManager. Capturing is done on other threads, depending on the OS
 // specific implementation.
@@ skipping 227 matching lines @@
     // The returned Buffer will always be allocated with a memory size suitable
     // for holding a packed video frame with pixels of |format| format, of
     // |dimensions| frame dimensions. It is permissible for |dimensions| to be
     // zero; in which case the returned Buffer does not guarantee memory
     // backing, but functions as a reservation for external input for the
     // purposes of buffer throttling.
     //
     // The output buffer stays reserved for use until the Buffer object is
     // destroyed.
     virtual scoped_refptr<Buffer> ReserveOutputBuffer(
-        media::VideoFrame::Format format,
-        const gfx::Size& dimensions) = 0;
+        const VideoCaptureFormat& format) = 0;

[miu, 2015/04/08 01:20:03]

Seems like this interface change is unnecsessary and complicates the calling
code.  Meaning, most of the callers of this method must now create a
VideoCaptureFormat temporary before calling ReserveOutputBuffer().  Is there a
reason you wanted to change it?

[mcasas, 2015/04/08 22:07:06]

No reason to bundle them but I changed
the first param from media::VideoFrame to
media::VideoPixelFormat, which is the enum
used by capture devices.

 
     // Captured a new video frame, held in |frame|.
     //
     // As the frame is backed by a reservation returned by
     // ReserveOutputBuffer(), delivery is guaranteed and will require no
     // additional copies in the browser process.
     virtual void OnIncomingCapturedVideoFrame(
         const scoped_refptr<Buffer>& buffer,
         const scoped_refptr<media::VideoFrame>& frame,
         const base::TimeTicks& timestamp) = 0;
@@ skipping 32 matching lines @@
   int GetPowerLineFrequencyForLocation() const;
 
  protected:
   static const int kPowerLine50Hz = 50;
   static const int kPowerLine60Hz = 60;
 };
 
 }  // namespace media
 
 #endif  // MEDIA_VIDEO_CAPTURE_VIDEO_CAPTURE_DEVICE_H_