Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1064543002: Set hovered state of current Hovered node even if it is also common ancestor of oldHovered node and (Closed)

Created:
5 years, 8 months ago by samahto
Modified:
5 years, 7 months ago
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Set hovered state of current Hovered node even if it is also common ancestor of oldHovered node and newHovered node. Before this patch if the commonAncestor of newHovered and oldHovered node is newHovered node then setHover gets ignored for newHovered node. BUG=95995 TEST=LayoutTests/fast/forms/hover-on-moving-mouse-checkbox-to-parent-label.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195446

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Incorporated review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -15 lines) Patch
A LayoutTests/fast/forms/label/hover-on-moving-mouse-checkbox-to-parent-label.html View 1 2 1 chunk +24 lines, -0 lines 0 comments Download
A LayoutTests/fast/forms/label/hover-on-moving-mouse-checkbox-to-parent-label-expected.html View 1 2 1 chunk +17 lines, -0 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLLabelElement.cpp View 1 chunk +14 lines, -14 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
samahto
Issue cause: When we move mouse from checkbox to label. checkbox is removed from hovered ...
5 years, 8 months ago (2015-04-04 19:12:39 UTC) #2
tkent
https://codereview.chromium.org/1064543002/diff/1/LayoutTests/fast/forms/hover-on-moving-mouse-checkbox-to-parent-label.html File LayoutTests/fast/forms/hover-on-moving-mouse-checkbox-to-parent-label.html (right): https://codereview.chromium.org/1064543002/diff/1/LayoutTests/fast/forms/hover-on-moving-mouse-checkbox-to-parent-label.html#newcode1 LayoutTests/fast/forms/hover-on-moving-mouse-checkbox-to-parent-label.html:1: <!DOCTYPE html> Please move this test to LayoutTests/fast/forms/label/. https://codereview.chromium.org/1064543002/diff/1/LayoutTests/fast/forms/hover-on-moving-mouse-checkbox-to-parent-label.html#newcode12 ...
5 years, 8 months ago (2015-04-07 03:41:45 UTC) #3
leviw_travelin_and_unemployed
> Before this patch we use to set hovered till commonAncestor so if s/use to ...
5 years, 8 months ago (2015-04-07 17:17:42 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1064543002/20001
5 years, 7 months ago (2015-05-14 04:54:59 UTC) #6
leviw_travelin_and_unemployed
tkent, keishi, this patch has been updated so PTAL.
5 years, 7 months ago (2015-05-14 04:56:14 UTC) #7
tkent
https://codereview.chromium.org/1064543002/diff/20001/LayoutTests/fast/forms/label/hover-on-moving-mouse-checkbox-to-parent-label-expected.html File LayoutTests/fast/forms/label/hover-on-moving-mouse-checkbox-to-parent-label-expected.html (right): https://codereview.chromium.org/1064543002/diff/20001/LayoutTests/fast/forms/label/hover-on-moving-mouse-checkbox-to-parent-label-expected.html#newcode6 LayoutTests/fast/forms/label/hover-on-moving-mouse-checkbox-to-parent-label-expected.html:6: input::after { Don't use :after for an input element. ...
5 years, 7 months ago (2015-05-14 05:24:00 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-14 06:25:38 UTC) #10
samahto
Requesting for review of updated patch with fixing review comments
5 years, 7 months ago (2015-05-17 20:56:05 UTC) #11
tkent
lgtm
5 years, 7 months ago (2015-05-17 23:58:39 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1064543002/40001
5 years, 7 months ago (2015-05-17 23:58:50 UTC) #14
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 01:16:56 UTC) #15
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195446

Powered by Google App Engine
This is Rietveld 408576698