Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Side by Side Diff: Source/core/dom/Document.cpp

Issue 1064543002: Set hovered state of current Hovered node even if it is also common ancestor of oldHovered node and (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Incorporated review comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved. 8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
(...skipping 5326 matching lines...) Expand 10 before | Expand all | Expand 10 after
5337 } 5337 }
5338 5338
5339 bool sawCommonAncestor = false; 5339 bool sawCommonAncestor = false;
5340 size_t addCount = nodesToAddToChain.size(); 5340 size_t addCount = nodesToAddToChain.size();
5341 for (size_t i = 0; i < addCount; ++i) { 5341 for (size_t i = 0; i < addCount; ++i) {
5342 // Elements past the common ancestor do not change hover state, but migh t change active state. 5342 // Elements past the common ancestor do not change hover state, but migh t change active state.
5343 if (ancestorNode && nodesToAddToChain[i] == ancestorNode) 5343 if (ancestorNode && nodesToAddToChain[i] == ancestorNode)
5344 sawCommonAncestor = true; 5344 sawCommonAncestor = true;
5345 if (allowActiveChanges) 5345 if (allowActiveChanges)
5346 nodesToAddToChain[i]->setActive(true); 5346 nodesToAddToChain[i]->setActive(true);
5347 if (!sawCommonAncestor) { 5347 if (!sawCommonAncestor || nodesToAddToChain[i] == m_hoverNode) {
5348 nodesToAddToChain[i]->setHovered(true); 5348 nodesToAddToChain[i]->setHovered(true);
5349 } 5349 }
5350 } 5350 }
5351 } 5351 }
5352 5352
5353 bool Document::haveStylesheetsLoaded() const 5353 bool Document::haveStylesheetsLoaded() const
5354 { 5354 {
5355 return m_styleEngine->haveStylesheetsLoaded(); 5355 return m_styleEngine->haveStylesheetsLoaded();
5356 } 5356 }
5357 5357
(...skipping 402 matching lines...) Expand 10 before | Expand all | Expand 10 after
5760 #ifndef NDEBUG 5760 #ifndef NDEBUG
5761 using namespace blink; 5761 using namespace blink;
5762 void showLiveDocumentInstances() 5762 void showLiveDocumentInstances()
5763 { 5763 {
5764 WeakDocumentSet& set = liveDocumentSet(); 5764 WeakDocumentSet& set = liveDocumentSet();
5765 fprintf(stderr, "There are %u documents currently alive:\n", set.size()); 5765 fprintf(stderr, "There are %u documents currently alive:\n", set.size());
5766 for (Document* document : set) 5766 for (Document* document : set)
5767 fprintf(stderr, "- Document %p URL: %s\n", document, document->url().str ing().utf8().data()); 5767 fprintf(stderr, "- Document %p URL: %s\n", document, document->url().str ing().utf8().data());
5768 } 5768 }
5769 #endif 5769 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698