Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 1064523003: Add "emulate push event" button to ServiceWorkersView in DevTools [1/2 chromium] (Closed)

Created:
5 years, 8 months ago by horo
Modified:
5 years, 8 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, jam, yurys, darin-cc_chromium.org, devtools-reviews_chromium.org, kinuko+watch, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add "emulate push event" button to ServiceWorkersView in DevTools [1/2 chromium] 1/2 chromium: This cl. 2/2 blink: https://codereview.chromium.org/1079013002/ Screenshot: https://code.google.com/p/chromium/issues/detail?id=474459#c4 BUG=474459 Committed: https://crrev.com/4d9399a2999fb38f3380ce46f703c4f200182651 Cr-Commit-Position: refs/heads/master@{#324674}

Patch Set 1 #

Total comments: 2

Patch Set 2 : s/dispatchPushEvent/deliverPushMessage/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M content/browser/devtools/protocol/service_worker_handler.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/devtools/protocol/service_worker_handler.cc View 1 3 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
horo
pfeldman@ Could you please review this?
5 years, 8 months ago (2015-04-10 08:15:56 UTC) #2
pfeldman
lgtm https://codereview.chromium.org/1064523003/diff/1/content/browser/devtools/protocol/service_worker_handler.cc File content/browser/devtools/protocol/service_worker_handler.cc (right): https://codereview.chromium.org/1064523003/diff/1/content/browser/devtools/protocol/service_worker_handler.cc#newcode373 content/browser/devtools/protocol/service_worker_handler.cc:373: BrowserContext::DeliverPushMessage( Or lets call it deliverPushMessage in the ...
5 years, 8 months ago (2015-04-10 11:55:33 UTC) #3
horo
https://codereview.chromium.org/1064523003/diff/1/content/browser/devtools/protocol/service_worker_handler.cc File content/browser/devtools/protocol/service_worker_handler.cc (right): https://codereview.chromium.org/1064523003/diff/1/content/browser/devtools/protocol/service_worker_handler.cc#newcode373 content/browser/devtools/protocol/service_worker_handler.cc:373: BrowserContext::DeliverPushMessage( On 2015/04/10 11:55:33, pfeldman wrote: > Or lets ...
5 years, 8 months ago (2015-04-10 16:58:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1064523003/20001
5 years, 8 months ago (2015-04-10 16:59:55 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-10 18:37:37 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-10 18:38:51 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4d9399a2999fb38f3380ce46f703c4f200182651
Cr-Commit-Position: refs/heads/master@{#324674}

Powered by Google App Engine
This is Rietveld 408576698