Source/core/html/HTMLCollection.h - Issue 106423003: [oilpan] Rename visit to mark.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLCollection.h

Issue 106423003: [oilpan] Rename visit to mark. (Closed) Base URL: svn://svn.chromium.org/blink/branches/oilpan

Patch Set: Fix typo Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLCollection.h

diff --git a/Source/core/html/HTMLCollection.h b/Source/core/html/HTMLCollection.h

index 266210af04dbd25920c8231b4362321c4f4b7a16..d0e8820ea1df97d3944bf5b97b8746527f0e6230 100644

--- a/Source/core/html/HTMLCollection.h

+++ b/Source/core/html/HTMLCollection.h

@@ -76,8 +76,6 @@ protected:

virtual void updateNameCache() const;

- // FIXME(oilpan): Move NodeList to the heap and visit members in NodeCacheMap.

- // See more discussion in https://codereview.chromium.org/23005018/

typedef HashMap<AtomicStringImpl*, Member<HeapVector<Member<Element> > > > NodeCacheMap;

HeapVector<Member<Element> >* idCache(const AtomicString& name) const { return m_idCache.get(name.impl()); }

HeapVector<Member<Element> >* nameCache(const AtomicString& name) const { return m_nameCache.get(name.impl()); }