Source/core/css/CSSFontSelector.cpp - Issue 106423003: [oilpan] Rename visit to mark.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSFontSelector.cpp

Issue 106423003: [oilpan] Rename visit to mark. (Closed) Base URL: svn://svn.chromium.org/blink/branches/oilpan

Patch Set: Fix typo Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/CSSFontSelector.cpp

diff --git a/Source/core/css/CSSFontSelector.cpp b/Source/core/css/CSSFontSelector.cpp

index 77ab74a9bd715d70aa55fa86e73540dbca2ca430..0af4d56e11c1411b50c76a5a9df50e75405fd107 100644

--- a/Source/core/css/CSSFontSelector.cpp

+++ b/Source/core/css/CSSFontSelector.cpp

@@ -629,10 +629,7 @@ void CSSFontSelector::beginLoadTimerFired(Timer<WebCore::CSSFontSelector>*)

void CSSFontSelector::trace(Visitor* visitor)

{

- // FIXME(oilpan): visiting m_document creates a cycle through a persistent handle because document owns StyleResolver

Mads Ager (chromium) 2013/12/05 12:10:01 The cycle described here no longer exists. We did

- // which hold CSSFontSelector via persistent handle. Once StyleResolver is moved to the heap we should start visiting

- // m_document again.

- // visitor->trace(m_document);

+ visitor->trace(m_document);

visitor->trace(m_fontFaces);

visitor->trace(m_locallyInstalledFontFaces);

visitor->trace(m_fonts);

« no previous file with comments | « no previous file | Source/core/css/CSSParser.cpp » ('j') | Source/core/html/HTMLCollection.cpp » ('J')