Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 1064123002: compositor-worker: Introduce CompositorProxy::disconnect(). (Closed)

Created:
5 years, 8 months ago by sadrul
Modified:
5 years, 8 months ago
Reviewers:
Ian Vollick, esprehn
CC:
arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-dom_chromium.org, Inactive, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, vivekg_samsung, vivekg
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

compositor-worker: Introduce CompositorProxy::disconnect(). Introduce CompositorProxy::disconnect() to allow disconnecting the proxy from the element. Trying to mutate a proxy or send the proxy over postMessage after disconnecting it from the element throws an exception. Other notable change: keep the number of active CompositorProxy objects for an Element in ElementRareData. BUG=436952 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193501

Patch Set 1 #

Patch Set 2 : self-nit #

Patch Set 3 : tot-merge+fix-test #

Patch Set 4 : . #

Patch Set 5 : self-nit #

Total comments: 3

Patch Set 6 : . #

Patch Set 7 : fix-win-for-realz #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -3 lines) Patch
A LayoutTests/fast/compositorworker/compositor-proxy-disconnect.html View 1 chunk +16 lines, -0 lines 0 comments Download
A LayoutTests/fast/compositorworker/compositor-proxy-disconnect-worker.html View 1 2 3 4 1 chunk +19 lines, -0 lines 0 comments Download
A LayoutTests/fast/compositorworker/resources/proxy-disconnect.js View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/core/v8/ScriptValueSerializer.cpp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/CompositorProxy.h View 2 chunks +5 lines, -0 lines 0 comments Download
M Source/core/dom/CompositorProxy.cpp View 5 chunks +39 lines, -2 lines 0 comments Download
M Source/core/dom/CompositorProxy.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/Element.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M Source/core/dom/ElementRareData.h View 1 2 3 4 5 6 3 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
sadrul
5 years, 8 months ago (2015-04-07 20:01:22 UTC) #2
Ian Vollick
On 2015/04/07 20:01:22, sadrul wrote: Thanks for doing this -- I'm glad that this will ...
5 years, 8 months ago (2015-04-08 22:19:20 UTC) #3
esprehn
This is making ElementRareData a lot bigger for a feature that will only be used ...
5 years, 8 months ago (2015-04-09 05:14:55 UTC) #4
sadrul
https://codereview.chromium.org/1064123002/diff/70001/Source/core/dom/ElementRareData.h File Source/core/dom/ElementRareData.h (right): https://codereview.chromium.org/1064123002/diff/70001/Source/core/dom/ElementRareData.h#newcode146 Source/core/dom/ElementRareData.h:146: uint32_t m_proxyCount; On 2015/04/09 05:14:55, esprehn wrote: > Do ...
5 years, 8 months ago (2015-04-09 16:19:33 UTC) #5
sadrul
https://codereview.chromium.org/1064123002/diff/70001/Source/core/dom/ElementRareData.h File Source/core/dom/ElementRareData.h (right): https://codereview.chromium.org/1064123002/diff/70001/Source/core/dom/ElementRareData.h#newcode146 Source/core/dom/ElementRareData.h:146: uint32_t m_proxyCount; On 2015/04/09 16:19:33, sadrul wrote: > On ...
5 years, 8 months ago (2015-04-09 16:41:10 UTC) #7
esprehn
lgtm, thanks!
5 years, 8 months ago (2015-04-09 19:18:34 UTC) #8
sadrul
I had to change from: unsigned m_tabStop : 1; unsigned m_proxyCount : 10; to unsigned ...
5 years, 8 months ago (2015-04-09 22:10:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1064123002/170001
5 years, 8 months ago (2015-04-09 22:11:29 UTC) #14
commit-bot: I haz the power
5 years, 8 months ago (2015-04-10 01:58:30 UTC) #15
Message was sent while issue was closed.
Committed patchset #7 (id:170001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193501

Powered by Google App Engine
This is Rietveld 408576698