Source/bindings/core/v8/ScriptValueSerializer.cpp - Issue 1064123002: compositor-worker: Introduce CompositorProxy::disconnect().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/ScriptValueSerializer.cpp

Issue 1064123002: compositor-worker: Introduce CompositorProxy::disconnect(). (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: fix-win-for-realz Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/core/v8/ScriptValueSerializer.cpp

diff --git a/Source/bindings/core/v8/ScriptValueSerializer.cpp b/Source/bindings/core/v8/ScriptValueSerializer.cpp

index 15644aa4921cdaa9e4f7775891bd547183cdc880..af0fa1b3736ac3796d03c9eceb79ea25b23d6924 100644

--- a/Source/bindings/core/v8/ScriptValueSerializer.cpp

+++ b/Source/bindings/core/v8/ScriptValueSerializer.cpp

@@ -836,6 +836,8 @@ ScriptValueSerializer::StateBase* ScriptValueSerializer::writeCompositorProxy(v8

CompositorProxy* compositorProxy = V8CompositorProxy::toImpl(value.As<v8::Object>());

if (!compositorProxy)

return nullptr;

+ if (!compositorProxy->connected())

+ return handleError(DataCloneError, "A CompositorProxy object has been disconnected, and could therefore not be cloned.", next);

m_writer.writeCompositorProxy(*compositorProxy);

return nullptr;

}