Issue 1064083003: Recover performance of array buffer view field accesses in ICs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1064083003: Recover performance of array buffer view field accesses in ICs (Closed)

Created:
5 years, 8 months ago by jochen (gone - plz use gerrit)

Modified:
5 years, 8 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Recover performance of array buffer view field accesses in ICs BUG=v8:3996 LOG=n

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+145 lines, -44 lines)			Patch
M	src/accessors.h	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/accessors.cc	View	1 chunk	+33 lines, -0 lines	0 comments	Download
M	src/code-stubs.h	View	2 chunks	+27 lines, -0 lines	0 comments	Download
M	src/code-stubs-hydrogen.cc	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	src/hydrogen.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/hydrogen.cc	View	2 chunks	+57 lines, -41 lines	0 comments	Download
M	src/ic/ic.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

Toon Verwaest

5 years, 8 months ago (2015-04-22 14:37:29 UTC) #2

lgtm
seems like there's some duplication you might get rid of though...