Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: src/accessors.cc

Issue 1064083003: Recover performance of array buffer view field accesses in ICs (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/accessors.h ('k') | src/code-stubs.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/accessors.cc
diff --git a/src/accessors.cc b/src/accessors.cc
index df981dc151a2362ed071f8be673efdf5d7189efb..ba977bc8dd989efa0256e42d60edcad085616132 100644
--- a/src/accessors.cc
+++ b/src/accessors.cc
@@ -93,6 +93,39 @@ bool Accessors::IsJSObjectFieldAccessor(Handle<Map> map, Handle<Name> name,
}
+bool Accessors::IsJSArrayBufferViewFieldAccessor(Handle<Map> map,
+ Handle<Name> name,
+ int* object_offset) {
+ Isolate* isolate = name->GetIsolate();
+
+ switch (map->instance_type()) {
+ case JS_TYPED_ARRAY_TYPE:
+ // %TypedArray%.prototype is non-configurable, and so are the following
+ // named properties on %TypedArray%.prototype, so we can directly inline
+ // the field-load for typed array maps that still use their
+ // %TypedArray%.prototype.
+ if (JSFunction::cast(map->GetConstructor())->prototype() !=
+ map->prototype()) {
+ return false;
+ }
+ return CheckForName(name, isolate->factory()->length_string(),
+ JSTypedArray::kLengthOffset, object_offset) ||
+ CheckForName(name, isolate->factory()->byte_length_string(),
+ JSTypedArray::kByteLengthOffset, object_offset) ||
+ CheckForName(name, isolate->factory()->byte_offset_string(),
+ JSTypedArray::kByteOffsetOffset, object_offset);
+
+ case JS_DATA_VIEW_TYPE:
+ return CheckForName(name, isolate->factory()->byte_length_string(),
+ JSDataView::kByteLengthOffset, object_offset) ||
+ CheckForName(name, isolate->factory()->byte_offset_string(),
+ JSDataView::kByteOffsetOffset, object_offset);
+ default:
+ return false;
+ }
+}
+
+
bool SetPropertyOnInstanceIfInherited(
Isolate* isolate, const v8::PropertyCallbackInfo<void>& info,
v8::Local<v8::Name> name, Handle<Object> value) {
« no previous file with comments | « src/accessors.h ('k') | src/code-stubs.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698