Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 1064073002: Revert of Revert of Revert of Revert of Revert of Enable ServiceWorkerPerfTest (service_worker.service_worker) (Closed)

Created:
5 years, 8 months ago by aiolos (Not reviewing)
Modified:
5 years, 8 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Revert of Revert of Revert of Enable ServiceWorkerPerfTest (service_worker.service_worker) (patchset #1 id:1 of https://codereview.chromium.org/1055533003/) Reason for revert: This is still failing on Android1. crbug.com/474658 Original issue's description: > Revert of Revert of Revert of Revert of Enable ServiceWorkerPerfTest (service_worker.service_worker) (patchset #1 id:1 of https://codereview.chromium.org/1000273003/) > > Reason for revert: > screenrecord is installed on Android One trybots. > https://code.google.com/p/chromium/issues/detail?id=469841#c8 > > Original issue's description: > > Revert of Revert of Revert of Enable ServiceWorkerPerfTest (service_worker.service_worker) (patchset #1 id:1 of https://codereview.chromium.org/1027743004/) > > > > Reason for revert: > > Failing on Android One perf bot which doesn't have "screenrecord". > > > > http://crbug.com/469841 > > > > Original issue's description: > > > Revert of Revert of Enable ServiceWorkerPerfTest (service_worker.service_worker) (patchset #1 id:1 of https://codereview.chromium.org/959793002/) > > > > > > Reason for revert: > > > avconv is available on Nexus 10. > > > https://code.google.com/p/chromium/issues/detail?id=433943#c37 > > > > > > Original issue's description: > > > > Revert of Enable ServiceWorkerPerfTest (service_worker.service_worker) (patchset #1 id:1 of https://codereview.chromium.org/954663002/) > > > > > > > > Reason for revert: > > > > Failing on Nexus 10. > > > > > > > > Original issue's description: > > > > > Enable ServiceWorkerPerfTest (service_worker.service_worker) > > > > > > > > > > I think https://codereview.chromium.org/884573004/ fixed the ServiceWorker test flakiness. > > > > > > > > > > BUG=433943 > > > > > TEST=./tools/perf/run_benchmark --browser-executable=~/chromium/src/out/Debug/chrome --also-run-disabled-tests service_worker.service_worker > > > > > > > > > > Committed: https://crrev.com/adaa44fc1275085c09fff18d8f2dfbddd88bc186 > > > > > Cr-Commit-Position: refs/heads/master@{#317807} > > > > > > > > TBR=falken@chromium.org,nednguyen@google.com,sullivan@chromium.org,horo@chromium.org > > > > NOPRESUBMIT=true > > > > NOTREECHECKS=true > > > > NOTRY=true > > > > BUG=433943 > > > > > > > > Committed: https://crrev.com/6aa34fa4e41d77e92d86f3f0c5f80fab9bdda749 > > > > Cr-Commit-Position: refs/heads/master@{#318066} > > > > > > TBR=falken@chromium.org,nednguyen@google.com,sullivan@chromium.org,simonhatch@chromium.org > > > NOPRESUBMIT=true > > > NOTREECHECKS=true > > > NOTRY=true > > > BUG=433943 > > > > > > Committed: https://crrev.com/e3f37ac21edb64dcf805007a382aff9405642948 > > > Cr-Commit-Position: refs/heads/master@{#321759} > > > > TBR=falken@chromium.org,nednguyen@google.com,sullivan@chromium.org,simonhatch@chromium.org > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=433943 > > > > Committed: https://crrev.com/7e894073084371a6c8c31827a0f0c9cdb37d4ed6 > > Cr-Commit-Position: refs/heads/master@{#321897} > > TBR=falken@chromium.org,nednguyen@google.com,sullivan@chromium.org,simonhatch@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=433943 > > Committed: https://crrev.com/19bdfcf548e5d04bfa1357d4df742664d9d5dfa9 > Cr-Commit-Position: refs/heads/master@{#323261} TBR=falken@chromium.org,nednguyen@google.com,sullivan@chromium.org,simonhatch@chromium.org,horo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=433943 Committed: https://crrev.com/8d0d03be9aaed6121770b32b3f4efd7830c2d962 Cr-Commit-Position: refs/heads/master@{#324070}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/perf/benchmarks/service_worker.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
aiolos (Not reviewing)
5 years, 8 months ago (2015-04-07 18:05:13 UTC) #1
Created Revert of Revert of Revert of Revert of Revert of Enable
ServiceWorkerPerfTest (service_worker.service_worker)

Powered by Google App Engine
This is Rietveld 408576698