Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Issue 1027743004: Revert of Revert of Enable ServiceWorkerPerfTest (service_worker.service_worker) (Closed)

Created:
5 years, 9 months ago by horo
Modified:
5 years, 9 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Enable ServiceWorkerPerfTest (service_worker.service_worker) (patchset #1 id:1 of https://codereview.chromium.org/959793002/) Reason for revert: avconv is available on Nexus 10. https://code.google.com/p/chromium/issues/detail?id=433943#c37 Original issue's description: > Revert of Enable ServiceWorkerPerfTest (service_worker.service_worker) (patchset #1 id:1 of https://codereview.chromium.org/954663002/) > > Reason for revert: > Failing on Nexus 10. > > Original issue's description: > > Enable ServiceWorkerPerfTest (service_worker.service_worker) > > > > I think https://codereview.chromium.org/884573004/ fixed the ServiceWorker test flakiness. > > > > BUG=433943 > > TEST=./tools/perf/run_benchmark --browser-executable=~/chromium/src/out/Debug/chrome --also-run-disabled-tests service_worker.service_worker > > > > Committed: https://crrev.com/adaa44fc1275085c09fff18d8f2dfbddd88bc186 > > Cr-Commit-Position: refs/heads/master@{#317807} > > TBR=falken@chromium.org,nednguyen@google.com,sullivan@chromium.org,horo@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=433943 > > Committed: https://crrev.com/6aa34fa4e41d77e92d86f3f0c5f80fab9bdda749 > Cr-Commit-Position: refs/heads/master@{#318066} TBR=falken@chromium.org,nednguyen@google.com,sullivan@chromium.org,simonhatch@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=433943 Committed: https://crrev.com/e3f37ac21edb64dcf805007a382aff9405642948 Cr-Commit-Position: refs/heads/master@{#321759}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M tools/perf/benchmarks/service_worker.py View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
horo
Created Revert of Revert of Enable ServiceWorkerPerfTest (service_worker.service_worker)
5 years, 9 months ago (2015-03-23 11:29:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1027743004/1
5 years, 9 months ago (2015-03-23 11:29:37 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-23 11:30:07 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e3f37ac21edb64dcf805007a382aff9405642948 Cr-Commit-Position: refs/heads/master@{#321759}
5 years, 9 months ago (2015-03-23 11:30:43 UTC) #4
horo
5 years, 9 months ago (2015-03-23 23:44:04 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1000273003/ by horo@chromium.org.

The reason for reverting is: Failing on Android One perf bot which doesn't have
"screenrecord".

http://crbug.com/469841.

Powered by Google App Engine
This is Rietveld 408576698