Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 1063913002: Revert of Remove ResourceFetcher's access to a real FetchContext at frame detach time (Closed)

Created:
5 years, 8 months ago by falken
Modified:
5 years, 8 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, dglazkov+blink, eae+blinkwatch, gavinp+loader_chromium.org, oilpan-reviews, rwlbuis, tyoshino+watch_chromium.org, webcomponents-bugzilla_chromium.org, dcheng
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Remove ResourceFetcher's access to a real FetchContext at frame detach time (patchset #4 id:60001 of https://codereview.chromium.org/1035803002/) Reason for revert: Causes an assert failure on imported/web-platform-tests/custom-elements/creating-and-passing-registries/share-registry-import-document.html ASSERTION FAILED: m_thread == currentThread() ../../third_party/WebKit/Source/platform/Timer.h(160) : bool blink::TimerBase::isActive() const 1 0x7f421ebb9357 2 0x7f422003e6bb 3 0x7f422003f214 4 0x7f4229e9ae37 blink::ThreadTimers::sharedTimerFiredInternal() 5 0x7f4229e9aa65 blink::ThreadTimers::sharedTimerFired() Example failure: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20(dbg)/builds/368 I verified locally that reverting fixes the test. Original issue's description: > Remove ResourceFetcher's access to a real FetchContext at frame detach time > > This allows us to remove a whole bunch of frame() null-checks in FrameFetchContext. > > BUG=458222 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193208 TBR=haraken@chromium.org,mkwst@chromium.org,sigbjornf@opera.com,japhet@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=458222 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193231

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -73 lines) Patch
M Source/core/dom/Document.cpp View 7 chunks +17 lines, -22 lines 0 comments Download
M Source/core/fetch/FetchContext.h View 1 chunk +4 lines, -3 lines 0 comments Download
M Source/core/fetch/FetchContext.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/fetch/ImageResourceTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/ResourceFetcher.h View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/fetch/ResourceFetcherTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/imports/HTMLImportLoader.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/imports/LinkImport.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/loader/DocumentLoader.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/loader/FrameFetchContext.h View 1 chunk +3 lines, -8 lines 0 comments Download
M Source/core/loader/FrameFetchContext.cpp View 22 chunks +73 lines, -20 lines 0 comments Download
M Source/core/loader/FrameFetchContextTest.cpp View 4 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
falken
Created Revert of Remove ResourceFetcher's access to a real FetchContext at frame detach time
5 years, 8 months ago (2015-04-07 01:03:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1063913002/1
5 years, 8 months ago (2015-04-07 01:03:34 UTC) #2
haraken
LGTM
5 years, 8 months ago (2015-04-07 01:04:00 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 01:04:03 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193231

Powered by Google App Engine
This is Rietveld 408576698