Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/browser/service_worker/service_worker_registration_status.cc

Issue 1063823005: Service Worker: Use more specific errors when StartWorker fails (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/service_worker/service_worker_register_job.cc ('k') | content/browser/service_worker/service_worker_version.h » ('j') | content/common/service_worker/service_worker_status_code.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/service_worker_registration_status.cc
diff --git a/content/browser/service_worker/service_worker_registration_status.cc b/content/browser/service_worker/service_worker_registration_status.cc
index 45b947d645e53eb6ed1887aca9e08541a8e22575..2904db966223c536c86b41a849fbc18755cf747c 100644
--- a/content/browser/service_worker/service_worker_registration_status.cc
+++ b/content/browser/service_worker/service_worker_registration_status.cc
@@ -28,13 +28,11 @@ void GetServiceWorkerRegistrationStatusResponse(
case SERVICE_WORKER_ERROR_START_WORKER_FAILED:
case SERVICE_WORKER_ERROR_INSTALL_WORKER_FAILED:
+ case SERVICE_WORKER_ERROR_PROCESS_NOT_FOUND:
+ case SERVICE_WORKER_ERROR_SCRIPT_EVALUATE_FAILED:
*error_type = WebServiceWorkerError::ErrorTypeInstall;
return;
- case SERVICE_WORKER_ERROR_ACTIVATE_WORKER_FAILED:
- *error_type = WebServiceWorkerError::ErrorTypeActivate;
- return;
-
case SERVICE_WORKER_ERROR_NOT_FOUND:
*error_type = WebServiceWorkerError::ErrorTypeNotFound;
return;
@@ -55,9 +53,9 @@ void GetServiceWorkerRegistrationStatusResponse(
*error_type = WebServiceWorkerError::ErrorTypeAbort;
return;
+ case SERVICE_WORKER_ERROR_ACTIVATE_WORKER_FAILED:
case SERVICE_WORKER_ERROR_IPC_FAILED:
case SERVICE_WORKER_ERROR_FAILED:
- case SERVICE_WORKER_ERROR_PROCESS_NOT_FOUND:
case SERVICE_WORKER_ERROR_EXISTS:
case SERVICE_WORKER_ERROR_EVENT_WAITUNTIL_REJECTED:
case SERVICE_WORKER_ERROR_STATE:
« no previous file with comments | « content/browser/service_worker/service_worker_register_job.cc ('k') | content/browser/service_worker/service_worker_version.h » ('j') | content/common/service_worker/service_worker_status_code.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698