Service Worker: Use more specific errors when StartWorker fails

content/browser/service_worker/service_worker_registration_status.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/service_worker/service_worker_registration_status.h"
 
 #include "base/logging.h"
 #include "base/strings/utf_string_conversions.h"
 
 namespace content {
@@ skipping 10 matching lines @@
     *message = base::UTF8ToUTF16(status_message);
   else
     *message = base::ASCIIToUTF16(ServiceWorkerStatusToString(status));
   switch (status) {
     case SERVICE_WORKER_OK:
       NOTREACHED() << "Calling this when status == OK is not allowed";
       return;
 
     case SERVICE_WORKER_ERROR_START_WORKER_FAILED:
     case SERVICE_WORKER_ERROR_INSTALL_WORKER_FAILED:
+    case SERVICE_WORKER_ERROR_PROCESS_NOT_FOUND:
+    case SERVICE_WORKER_ERROR_SCRIPT_EVALUATE_FAILED:
       *error_type = WebServiceWorkerError::ErrorTypeInstall;
       return;
 
-    case SERVICE_WORKER_ERROR_ACTIVATE_WORKER_FAILED:
-      *error_type = WebServiceWorkerError::ErrorTypeActivate;
-      return;
-
     case SERVICE_WORKER_ERROR_NOT_FOUND:
       *error_type = WebServiceWorkerError::ErrorTypeNotFound;
       return;
 
     case SERVICE_WORKER_ERROR_NETWORK:
       *error_type = WebServiceWorkerError::ErrorTypeNetwork;
       return;
 
     case SERVICE_WORKER_ERROR_SECURITY:
       *error_type = WebServiceWorkerError::ErrorTypeSecurity;
       return;
 
     case SERVICE_WORKER_ERROR_TIMEOUT:
       *error_type = WebServiceWorkerError::ErrorTypeTimeout;
       return;
 
     case SERVICE_WORKER_ERROR_ABORT:
       *error_type = WebServiceWorkerError::ErrorTypeAbort;
       return;
 
+    case SERVICE_WORKER_ERROR_ACTIVATE_WORKER_FAILED:
     case SERVICE_WORKER_ERROR_IPC_FAILED:
     case SERVICE_WORKER_ERROR_FAILED:
-    case SERVICE_WORKER_ERROR_PROCESS_NOT_FOUND:
     case SERVICE_WORKER_ERROR_EXISTS:
     case SERVICE_WORKER_ERROR_EVENT_WAITUNTIL_REJECTED:
     case SERVICE_WORKER_ERROR_STATE:
     case SERVICE_WORKER_ERROR_MAX_VALUE:
       // Unexpected, or should have bailed out before calling this, or we don't
       // have a corresponding blink error code yet.
       break;  // Fall through to NOTREACHED().
   }
   NOTREACHED() << "Got unexpected error code: "
                << status << " " << ServiceWorkerStatusToString(status);
 }
 
 }  // namespace content