Restructured PlatformVerificationFlow testing.

Restructured PlatformVerificationFlow testing.

Also added a unit test for incognito / guest mode.

BUG=chromium:328539
TEST=unit

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242157

[Mattias Nissler (ping if slow), 2013-12-19 09:21:12]

This change LGTM, but cleaning up the HCSM pref registrations duplication would
be a good thing to do.

https://codereview.chromium.org/106373003/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/attestation/platform_verification_flow_unittest.cc
(right):

https://codereview.chromium.org/106373003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/attestation/platform_verification_flow_unittest.cc:51:
void RegisterHostContentSettingsPrefs(PrefRegistrySimple* registry) {
This is fragile - you now need to keep this code in sync with
HostContentSettingsMap::RegisterProfilePrefs. Have you considered using
TestingPrefServiceSyncable instead and just calling
HostContentSettingsMap::RegisterProfilePrefs?

[Darren Krahn, 2013-12-20 01:54:21]

Pref registration cleaned up also -- PTAL

https://codereview.chromium.org/106373003/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/attestation/platform_verification_flow_unittest.cc
(right):

https://codereview.chromium.org/106373003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/attestation/platform_verification_flow_unittest.cc:51:
void RegisterHostContentSettingsPrefs(PrefRegistrySimple* registry) {
On 2013/12/19 09:21:13, Mattias Nissler wrote:
> This is fragile - you now need to keep this code in sync with
> HostContentSettingsMap::RegisterProfilePrefs. Have you considered using
> TestingPrefServiceSyncable instead and just calling
> HostContentSettingsMap::RegisterProfilePrefs?

Yeah, I was looking at this thinking there must be a better way but I didn't
know about / find TestingPrefServiceSyncable.  It's a bit confusing how prefs
code is scattered across base/components/browser.  Works great though -- Done.

[Mattias Nissler (ping if slow), 2013-12-20 12:46:17]

LGTM, good cleanup!

https://codereview.chromium.org/106373003/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/attestation/platform_verification_flow_unittest.cc
(right):

https://codereview.chromium.org/106373003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/attestation/platform_verification_flow_unittest.cc:51:
void RegisterHostContentSettingsPrefs(PrefRegistrySimple* registry) {
On 2013/12/20 01:54:21, Darren Krahn wrote:
> On 2013/12/19 09:21:13, Mattias Nissler wrote:
> > This is fragile - you now need to keep this code in sync with
> > HostContentSettingsMap::RegisterProfilePrefs. Have you considered using
> > TestingPrefServiceSyncable instead and just calling
> > HostContentSettingsMap::RegisterProfilePrefs?
> 
> Yeah, I was looking at this thinking there must be a better way but I didn't
> know about / find TestingPrefServiceSyncable.  It's a bit confusing how prefs
> code is scattered across base/components/browser.  Works great though -- Done.

We call this componentization ;)

[commit-bot: I haz the power, 2013-12-20 17:29:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dkrahn@chromium.org/106373003/40001

[commit-bot: I haz the power, 2013-12-20 20:08:35]

Change committed as 242157