Restructured PlatformVerificationFlow testing.

chrome/browser/chromeos/attestation/platform_verification_flow_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/message_loop/message_loop.h"
 #include "base/prefs/pref_registry_simple.h"
 #include "base/prefs/testing_pref_service.h"
@@ skipping 30 matching lines @@
 
 const char kTestID[] = "test_id";
 const char kTestChallenge[] = "test_challenge";
 const char kTestSignedData[] = "test_challenge_with_salt";
 const char kTestSignature[] = "test_signature";
 const char kTestCertificate[] = "test_certificate";
 const char kTestEmail[] = "test_email@chromium.org";
 const char kTestURL[] = "http://mytestdomain/test";
 const char kTestURLSecure[] = "https://mytestdomain/test";
 
+void RegisterHostContentSettingsPrefs(PrefRegistrySimple* registry) {

[Mattias Nissler (ping if slow), 2013/12/19 09:21:13]

This is fragile - you now need to keep this code in sync with
HostContentSettingsMap::RegisterProfilePrefs. Have you considered using
TestingPrefServiceSyncable instead and just calling
HostContentSettingsMap::RegisterProfilePrefs?

[Darren Krahn, 2013/12/20 01:54:21]

Yeah, I was looking at this thinking there must be a better way but I didn't
know about / find TestingPrefServiceSyncable.  It's a bit confusing how prefs
code is scattered across base/components/browser.  Works great though -- Done.

[Mattias Nissler (ping if slow), 2013/12/20 12:46:17]

We call this componentization ;)

+  registry->RegisterIntegerPref(
+      prefs::kContentSettingsWindowLastTabIndex,
+      0);
+  registry->RegisterIntegerPref(
+      prefs::kContentSettingsDefaultWhitelistVersion,
+      0);
+  registry->RegisterBooleanPref(
+      prefs::kContentSettingsClearOnExitMigrated,
+      false);
+  DictionaryValue* default_content_settings = new DictionaryValue();
+  registry->RegisterDictionaryPref(
+      prefs::kDefaultContentSettings,
+      default_content_settings);
+  registry->RegisterIntegerPref(
+      prefs::kContentSettingsVersion,
+      ContentSettingsPattern::kContentSettingsPatternVersion);
+  registry->RegisterDictionaryPref(
+      prefs::kContentSettingsPatternPairs);
+  registry->RegisterListPref(prefs::kManagedAutoSelectCertificateForUrls);
+  registry->RegisterListPref(prefs::kManagedCookiesAllowedForUrls);
+  registry->RegisterListPref(prefs::kManagedCookiesBlockedForUrls);
+  registry->RegisterListPref(prefs::kManagedCookiesSessionOnlyForUrls);
+  registry->RegisterListPref(prefs::kManagedImagesAllowedForUrls);
+  registry->RegisterListPref(prefs::kManagedImagesBlockedForUrls);
+  registry->RegisterListPref(prefs::kManagedJavaScriptAllowedForUrls);
+  registry->RegisterListPref(prefs::kManagedJavaScriptBlockedForUrls);
+  registry->RegisterListPref(prefs::kManagedPluginsAllowedForUrls);
+  registry->RegisterListPref(prefs::kManagedPluginsBlockedForUrls);
+  registry->RegisterListPref(prefs::kManagedPopupsAllowedForUrls);
+  registry->RegisterListPref(prefs::kManagedPopupsBlockedForUrls);
+  registry->RegisterListPref(prefs::kManagedNotificationsAllowedForUrls);
+  registry->RegisterListPref(prefs::kManagedNotificationsBlockedForUrls);
+  registry->RegisterIntegerPref(
+      prefs::kManagedDefaultCookiesSetting,
+      CONTENT_SETTING_DEFAULT);
+  registry->RegisterIntegerPref(
+      prefs::kManagedDefaultImagesSetting,
+      CONTENT_SETTING_DEFAULT);
+  registry->RegisterIntegerPref(
+      prefs::kManagedDefaultJavaScriptSetting,
+      CONTENT_SETTING_DEFAULT);
+  registry->RegisterIntegerPref(
+      prefs::kManagedDefaultPluginsSetting,
+      CONTENT_SETTING_DEFAULT);
+  registry->RegisterIntegerPref(
+      prefs::kManagedDefaultPopupsSetting,
+      CONTENT_SETTING_DEFAULT);
+  registry->RegisterIntegerPref(
+      prefs::kManagedDefaultGeolocationSetting,
+      CONTENT_SETTING_DEFAULT);
+  registry->RegisterIntegerPref(
+      prefs::kManagedDefaultNotificationsSetting,
+      CONTENT_SETTING_DEFAULT);
+  registry->RegisterIntegerPref(
+      prefs::kManagedDefaultMediaStreamSetting,
+      CONTENT_SETTING_DEFAULT);
+  registry->RegisterBooleanPref(
+      prefs::kClearSiteDataOnExit,
+      false);
+}
+
 class FakeDelegate : public PlatformVerificationFlow::Delegate {
  public:
   FakeDelegate() : response_(PlatformVerificationFlow::CONSENT_RESPONSE_ALLOW),
-                   num_consent_calls_(0) {}
+                   num_consent_calls_(0),
+                   url_(kTestURL),
+                   is_incognito_(false) {
+    // Configure a user for the mock user manager.
+    mock_user_manager_.SetActiveUser(kTestEmail);
+  }
   virtual ~FakeDelegate() {}
 
+  void SetUp() {
+    // Configure a test pref service.
+    pref_service_.registry()->RegisterBooleanPref(prefs::kEnableDRM, true);
+    pref_service_.registry()->RegisterBooleanPref(prefs::kRAConsentFirstTime,
+                                                  true);
+    RegisterHostContentSettingsPrefs(pref_service_.registry());
+    content_settings_ = new HostContentSettingsMap(&pref_service_, false);
+  }
+
+  void TearDown() {
+    content_settings_->ShutdownOnUIThread();
+  }
+
   virtual void ShowConsentPrompt(
       content::WebContents* web_contents,
       const PlatformVerificationFlow::Delegate::ConsentCallback& callback)
       OVERRIDE {
     num_consent_calls_++;
     callback.Run(response_);
   }
 
+  virtual PrefService* GetPrefs(content::WebContents* web_contents) OVERRIDE {
+    return &pref_service_;
+  }
+
+  virtual const GURL& GetURL(content::WebContents* web_contents) OVERRIDE {
+    return url_;
+  }
+
+  virtual User* GetUser(content::WebContents* web_contents) OVERRIDE {
+    return mock_user_manager_.GetActiveUser();
+  }
+
+  virtual HostContentSettingsMap* GetContentSettings(
+      content::WebContents* web_contents) OVERRIDE {
+    return content_settings_;
+  }
+
+  virtual bool IsGuestOrIncognito(content::WebContents* web_contents) OVERRIDE {
+    return is_incognito_;
+  }
+
   void set_response(PlatformVerificationFlow::ConsentResponse response) {
     response_ = response;
   }
 
   int num_consent_calls() {
     return num_consent_calls_;
   }
 
+  TestingPrefServiceSimple& pref_service() {
+    return pref_service_;
+  }
+
+  void set_url(const GURL& url) {
+    url_ = url;
+  }
+
+  void set_is_incognito(bool is_incognito) {
+    is_incognito_ = is_incognito;
+  }
+
  private:
   PlatformVerificationFlow::ConsentResponse response_;
   int num_consent_calls_;
+  TestingPrefServiceSimple pref_service_;
+  MockUserManager mock_user_manager_;
+  GURL url_;
+  scoped_refptr<HostContentSettingsMap> content_settings_;
+  bool is_incognito_;
 
   DISALLOW_COPY_AND_ASSIGN(FakeDelegate);
 };
 
 class CustomFakeCryptohomeClient : public FakeCryptohomeClient {
  public:
   CustomFakeCryptohomeClient() : call_status_(DBUS_METHOD_CALL_SUCCESS),
                                  attestation_enrolled_(true),
                                  attestation_prepared_(true) {}
   virtual void TpmAttestationIsEnrolled(
@@ skipping 36 matching lines @@
  public:
   PlatformVerificationFlowTest()
       : message_loop_(base::MessageLoop::TYPE_UI),
         ui_thread_(content::BrowserThread::UI, &message_loop_),
         certificate_success_(true),
         fake_certificate_index_(0),
         sign_challenge_success_(true),
         result_(PlatformVerificationFlow::INTERNAL_ERROR) {}
 
   void SetUp() {
-    // Configure a user for the mock user manager.
-    mock_user_manager_.SetActiveUser(kTestEmail);
+    fake_delegate_.SetUp();
 
     // Create a verifier for tests to call.
     verifier_ = new PlatformVerificationFlow(&mock_attestation_flow_,
                                              &mock_async_caller_,
                                              &fake_cryptohome_client_,
-                                             &mock_user_manager_,
                                              &fake_delegate_);
 
     // Create callbacks for tests to use with verifier_.
     callback_ = base::Bind(&PlatformVerificationFlowTest::FakeChallengeCallback,
                            base::Unretained(this));
 
-    // Configure the test pref service.
-    pref_service_.registry()->RegisterBooleanPref(prefs::kEnableDRM, true);
-    pref_service_.registry()->RegisterBooleanPref(prefs::kRAConsentFirstTime,
-                                                  true);
-    RegisterHostContentSettingsPrefs(pref_service_.registry());
-    verifier_->set_testing_prefs(&pref_service_);
-    test_content_settings_ = new HostContentSettingsMap(&pref_service_, false);
-    verifier_->set_testing_content_settings(test_content_settings_);
-
     // Configure the global cros_settings.
     CrosSettings* cros_settings = CrosSettings::Get();
     device_settings_provider_ =
         cros_settings->GetProvider(kAttestationForContentProtectionEnabled);
     cros_settings->RemoveSettingsProvider(device_settings_provider_);
     cros_settings->AddSettingsProvider(&stub_settings_provider_);
     cros_settings->SetBoolean(kAttestationForContentProtectionEnabled, true);
-
-    // Configure a test URL to shortcut the dependency on WebContents.
-    verifier_->set_testing_url(GURL(kTestURL));
-  }
-
-  void RegisterHostContentSettingsPrefs(PrefRegistrySimple* registry) {
-    registry->RegisterIntegerPref(
-        prefs::kContentSettingsWindowLastTabIndex,
-        0);
-    registry->RegisterIntegerPref(
-        prefs::kContentSettingsDefaultWhitelistVersion,
-        0);
-    registry->RegisterBooleanPref(
-        prefs::kContentSettingsClearOnExitMigrated,
-        false);
-    DictionaryValue* default_content_settings = new DictionaryValue();
-    registry->RegisterDictionaryPref(
-        prefs::kDefaultContentSettings,
-        default_content_settings);
-    registry->RegisterIntegerPref(
-        prefs::kContentSettingsVersion,
-        ContentSettingsPattern::kContentSettingsPatternVersion);
-    registry->RegisterDictionaryPref(
-        prefs::kContentSettingsPatternPairs);
-    registry->RegisterListPref(prefs::kManagedAutoSelectCertificateForUrls);
-    registry->RegisterListPref(prefs::kManagedCookiesAllowedForUrls);
-    registry->RegisterListPref(prefs::kManagedCookiesBlockedForUrls);
-    registry->RegisterListPref(prefs::kManagedCookiesSessionOnlyForUrls);
-    registry->RegisterListPref(prefs::kManagedImagesAllowedForUrls);
-    registry->RegisterListPref(prefs::kManagedImagesBlockedForUrls);
-    registry->RegisterListPref(prefs::kManagedJavaScriptAllowedForUrls);
-    registry->RegisterListPref(prefs::kManagedJavaScriptBlockedForUrls);
-    registry->RegisterListPref(prefs::kManagedPluginsAllowedForUrls);
-    registry->RegisterListPref(prefs::kManagedPluginsBlockedForUrls);
-    registry->RegisterListPref(prefs::kManagedPopupsAllowedForUrls);
-    registry->RegisterListPref(prefs::kManagedPopupsBlockedForUrls);
-    registry->RegisterListPref(prefs::kManagedNotificationsAllowedForUrls);
-    registry->RegisterListPref(prefs::kManagedNotificationsBlockedForUrls);
-    registry->RegisterIntegerPref(
-        prefs::kManagedDefaultCookiesSetting,
-        CONTENT_SETTING_DEFAULT);
-    registry->RegisterIntegerPref(
-        prefs::kManagedDefaultImagesSetting,
-        CONTENT_SETTING_DEFAULT);
-    registry->RegisterIntegerPref(
-        prefs::kManagedDefaultJavaScriptSetting,
-        CONTENT_SETTING_DEFAULT);
-    registry->RegisterIntegerPref(
-        prefs::kManagedDefaultPluginsSetting,
-        CONTENT_SETTING_DEFAULT);
-    registry->RegisterIntegerPref(
-        prefs::kManagedDefaultPopupsSetting,
-        CONTENT_SETTING_DEFAULT);
-    registry->RegisterIntegerPref(
-        prefs::kManagedDefaultGeolocationSetting,
-        CONTENT_SETTING_DEFAULT);
-    registry->RegisterIntegerPref(
-        prefs::kManagedDefaultNotificationsSetting,
-        CONTENT_SETTING_DEFAULT);
-    registry->RegisterIntegerPref(
-        prefs::kManagedDefaultMediaStreamSetting,
-        CONTENT_SETTING_DEFAULT);
-    registry->RegisterBooleanPref(
-        prefs::kClearSiteDataOnExit,
-        false);
   }
 
   void TearDown() {
     // Restore the real DeviceSettingsProvider.
     CrosSettings* cros_settings = CrosSettings::Get();
     cros_settings->RemoveSettingsProvider(&stub_settings_provider_);
     cros_settings->AddSettingsProvider(device_settings_provider_);
-    test_content_settings_->ShutdownOnUIThread();
+    fake_delegate_.TearDown();
   }
 
   void ExpectAttestationFlow() {
     // When consent is not given or the feature is disabled, it is important
     // that there are no calls to the attestation service.  Thus, a test must
     // explicitly expect these calls or the mocks will fail the test.
 
     // Configure the mock AttestationFlow to call FakeGetCertificate.
     EXPECT_CALL(mock_attestation_flow_,
                 GetCertificate(PROFILE_CONTENT_PROTECTION_CERTIFICATE,
                                kTestEmail, kTestID, _, _))
         .WillRepeatedly(WithArgs<4>(Invoke(
             this, &PlatformVerificationFlowTest::FakeGetCertificate)));
 
     // Configure the mock AsyncMethodCaller to call FakeSignChallenge.
     std::string expected_key_name = std::string(kContentProtectionKeyPrefix) +
                                     std::string(kTestID);
     EXPECT_CALL(mock_async_caller_,
                 TpmAttestationSignSimpleChallenge(KEY_USER, kTestEmail,
                                                   expected_key_name,
                                                   kTestChallenge, _))
         .WillRepeatedly(WithArgs<4>(Invoke(
             this, &PlatformVerificationFlowTest::FakeSignChallenge)));
   }
 
   void SetUserConsent(const GURL& url, bool allow) {
-    verifier_->RecordDomainConsent(test_content_settings_, url, allow);
-  }
-
-  void SetURL(const GURL& url) {
-    verifier_->set_testing_url(url);
+    verifier_->RecordDomainConsent(fake_delegate_.GetContentSettings(NULL),
+                                   url,
+                                   allow);
   }
 
   void FakeGetCertificate(
       const AttestationFlow::CertificateCallback& callback) {
     std::string certificate =
         (fake_certificate_index_ < fake_certificate_list_.size()) ?
             fake_certificate_list_[fake_certificate_index_] : kTestCertificate;
     base::MessageLoop::current()->PostTask(FROM_HERE,
                                            base::Bind(callback,
                                                       certificate_success_,
@@ skipping 28 matching lines @@
     CHECK(pb.SerializeToString(&serial));
     return serial;
   }
 
  protected:
   base::MessageLoop message_loop_;
   content::TestBrowserThread ui_thread_;
   StrictMock<MockAttestationFlow> mock_attestation_flow_;
   cryptohome::MockAsyncMethodCaller mock_async_caller_;
   CustomFakeCryptohomeClient fake_cryptohome_client_;
-  MockUserManager mock_user_manager_;
   FakeDelegate fake_delegate_;
-  TestingPrefServiceSimple pref_service_;
   CrosSettingsProvider* device_settings_provider_;
   StubCrosSettingsProvider stub_settings_provider_;
   ScopedTestDeviceSettingsService test_device_settings_service_;
   ScopedTestCrosSettings test_cros_settings_;
-  scoped_refptr<HostContentSettingsMap> test_content_settings_;
   scoped_refptr<PlatformVerificationFlow> verifier_;
 
   // Controls result of FakeGetCertificate.
   bool certificate_success_;
   std::vector<std::string> fake_certificate_list_;
   size_t fake_certificate_index_;
 
   // Controls result of FakeSignChallenge.
   bool sign_challenge_success_;
 
@@ skipping 27 matching lines @@
   base::RunLoop().RunUntilIdle();
   EXPECT_EQ(PlatformVerificationFlow::SUCCESS, result_);
   EXPECT_EQ(kTestSignedData, challenge_salt_);
   EXPECT_EQ(kTestSignature, challenge_signature_);
   EXPECT_EQ(kTestCertificate, certificate_);
   EXPECT_EQ(1, fake_delegate_.num_consent_calls());
 }
 
 TEST_F(PlatformVerificationFlowTest, SuccessWithFirstTimeConsent) {
   SetUserConsent(GURL(kTestURL), true);
-  pref_service_.SetUserPref(prefs::kRAConsentFirstTime,
-                            new base::FundamentalValue(false));
+  fake_delegate_.pref_service().SetUserPref(prefs::kRAConsentFirstTime,
+                                            new base::FundamentalValue(false));
   ExpectAttestationFlow();
   verifier_->ChallengePlatformKey(NULL, kTestID, kTestChallenge, callback_);
   base::RunLoop().RunUntilIdle();
   EXPECT_EQ(PlatformVerificationFlow::SUCCESS, result_);
   EXPECT_EQ(kTestSignedData, challenge_salt_);
   EXPECT_EQ(kTestSignature, challenge_signature_);
   EXPECT_EQ(kTestCertificate, certificate_);
   EXPECT_EQ(1, fake_delegate_.num_consent_calls());
 }
 
 TEST_F(PlatformVerificationFlowTest, ConsentRejected) {
   fake_delegate_.set_response(PlatformVerificationFlow::CONSENT_RESPONSE_DENY);
   verifier_->ChallengePlatformKey(NULL, kTestID, kTestChallenge, callback_);
   base::RunLoop().RunUntilIdle();
   EXPECT_EQ(PlatformVerificationFlow::USER_REJECTED, result_);
   EXPECT_EQ(1, fake_delegate_.num_consent_calls());
 }
 
 TEST_F(PlatformVerificationFlowTest, FeatureDisabled) {
   CrosSettings::Get()->SetBoolean(kAttestationForContentProtectionEnabled,
                                   false);
   verifier_->ChallengePlatformKey(NULL, kTestID, kTestChallenge, callback_);
   base::RunLoop().RunUntilIdle();
   EXPECT_EQ(PlatformVerificationFlow::POLICY_REJECTED, result_);
   EXPECT_EQ(0, fake_delegate_.num_consent_calls());
 }
 
 TEST_F(PlatformVerificationFlowTest, FeatureDisabledByUser) {
-  pref_service_.SetUserPref(prefs::kEnableDRM,
-                            new base::FundamentalValue(false));
+  fake_delegate_.pref_service().SetUserPref(prefs::kEnableDRM,
+                                            new base::FundamentalValue(false));
   verifier_->ChallengePlatformKey(NULL, kTestID, kTestChallenge, callback_);
   base::RunLoop().RunUntilIdle();
   EXPECT_EQ(PlatformVerificationFlow::POLICY_REJECTED, result_);
   EXPECT_EQ(0, fake_delegate_.num_consent_calls());
 }
 
 TEST_F(PlatformVerificationFlowTest, FeatureDisabledByUserForDomain) {
   SetUserConsent(GURL(kTestURL), false);
   verifier_->ChallengePlatformKey(NULL, kTestID, kTestChallenge, callback_);
   base::RunLoop().RunUntilIdle();
@@ skipping 34 matching lines @@
 TEST_F(PlatformVerificationFlowTest, ConsentPerScheme) {
   fake_delegate_.set_response(PlatformVerificationFlow::CONSENT_RESPONSE_DENY);
   verifier_->ChallengePlatformKey(NULL, kTestID, kTestChallenge, callback_);
   base::RunLoop().RunUntilIdle();
   EXPECT_EQ(PlatformVerificationFlow::USER_REJECTED, result_);
   // Call again and expect denial based on previous response.
   verifier_->ChallengePlatformKey(NULL, kTestID, kTestChallenge, callback_);
   base::RunLoop().RunUntilIdle();
   EXPECT_EQ(PlatformVerificationFlow::POLICY_REJECTED, result_);
   // Call with a different scheme and expect another consent prompt.
-  SetURL(GURL(kTestURLSecure));
+  fake_delegate_.set_url(GURL(kTestURLSecure));
   verifier_->ChallengePlatformKey(NULL, kTestID, kTestChallenge, callback_);
   base::RunLoop().RunUntilIdle();
   EXPECT_EQ(PlatformVerificationFlow::USER_REJECTED, result_);
   EXPECT_EQ(2, fake_delegate_.num_consent_calls());
 }
 
 TEST_F(PlatformVerificationFlowTest, Timeout) {
   verifier_->set_timeout_delay(base::TimeDelta::FromSeconds(0));
   ExpectAttestationFlow();
   verifier_->ChallengePlatformKey(NULL, kTestID, kTestChallenge, callback_);
   base::RunLoop().RunUntilIdle();
   EXPECT_EQ(PlatformVerificationFlow::TIMEOUT, result_);
 }
 
 TEST_F(PlatformVerificationFlowTest, ExpiredCert) {
   ExpectAttestationFlow();
   fake_certificate_list_.resize(2);
   ASSERT_TRUE(GetFakeCertificate(base::TimeDelta::FromDays(-1),
                                  &fake_certificate_list_[0]));
   ASSERT_TRUE(GetFakeCertificate(base::TimeDelta::FromDays(1),
                                  &fake_certificate_list_[1]));
   verifier_->ChallengePlatformKey(NULL, kTestID, kTestChallenge, callback_);
   base::RunLoop().RunUntilIdle();
   EXPECT_EQ(PlatformVerificationFlow::SUCCESS, result_);
   EXPECT_EQ(certificate_, fake_certificate_list_[1]);
 }
 
+TEST_F(PlatformVerificationFlowTest, IncognitoMode) {
+  fake_delegate_.set_is_incognito(true);
+  verifier_->ChallengePlatformKey(NULL, kTestID, kTestChallenge, callback_);
+  base::RunLoop().RunUntilIdle();
+  EXPECT_EQ(PlatformVerificationFlow::PLATFORM_NOT_VERIFIED, result_);
+}
+
 }  // namespace attestation
 }  // namespace chromeos