Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 1063563002: Simplify the interface to ProxyClientSocket::BuildTunnelRequest (Closed)

Created:
5 years, 8 months ago by Ryan Hamilton
Modified:
5 years, 8 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, Bence
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify the interface to ProxyClientSocket::BuildTunnelRequest to only take the user-agent instead of a full HttpRequestInfo object. This also changes the host header being sent in CONNECT requests to include the port if it is 80, to match the behavior of the spec: https://www.ietf.org/rfc/rfc2817.txt Remove unused url argument to LogBlockedTunnelResponse Committed: https://crrev.com/cb934f563776e71df0e523f783496722acc99546 Cr-Commit-Position: refs/heads/master@{#324054}

Patch Set 1 #

Patch Set 2 : LogBlockedTunnelResponse #

Patch Set 3 : fix a jingle test #

Patch Set 4 : Fix WebSocketStreamCreateTest.HandleErrTunnelConnectionFailed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -37 lines) Patch
M jingle/glue/proxy_resolving_client_socket_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_network_transaction_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_proxy_client_socket.cc View 1 2 chunks +6 lines, -2 lines 0 comments Download
M net/http/proxy_client_socket.h View 1 2 chunks +2 lines, -3 lines 0 comments Download
M net/http/proxy_client_socket.cc View 1 2 chunks +9 lines, -11 lines 0 comments Download
M net/socket/ssl_client_socket_pool_unittest.cc View 4 chunks +11 lines, -9 lines 0 comments Download
M net/spdy/spdy_network_transaction_unittest.cc View 2 chunks +8 lines, -6 lines 0 comments Download
M net/spdy/spdy_proxy_client_socket.cc View 1 2 chunks +7 lines, -3 lines 0 comments Download
M net/websockets/websocket_stream_test.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (9 generated)
Ryan Hamilton
I'm going to clean up part of the client socket pool interface to remove the ...
5 years, 8 months ago (2015-04-04 15:24:06 UTC) #2
Ryan Hamilton
bnc: FYI. This is part of an attempt to remove alternative_service_url_ in HttpStreamFactoryImpl::Job
5 years, 8 months ago (2015-04-04 15:32:33 UTC) #3
ramant (doing other things)
lgtm
5 years, 8 months ago (2015-04-05 16:29:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1063563002/20001
5 years, 8 months ago (2015-04-05 16:31:27 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/4813)
5 years, 8 months ago (2015-04-05 17:44:03 UTC) #8
Ryan Hamilton
sergeyu: Can you approve the change to jingle/glue/proxy_resolving_client_socket_unittest.cc
5 years, 8 months ago (2015-04-06 02:25:29 UTC) #10
Sergey Ulanov
lgtm
5 years, 8 months ago (2015-04-06 17:58:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1063563002/40001
5 years, 8 months ago (2015-04-06 18:12:19 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/4907)
5 years, 8 months ago (2015-04-06 19:28:22 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1063563002/60001
5 years, 8 months ago (2015-04-07 15:06:02 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 8 months ago (2015-04-07 16:25:22 UTC) #20
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 16:27:25 UTC) #21
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/cb934f563776e71df0e523f783496722acc99546
Cr-Commit-Position: refs/heads/master@{#324054}

Powered by Google App Engine
This is Rietveld 408576698