Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1192)

Unified Diff: net/http/proxy_client_socket.h

Issue 1063563002: Simplify the interface to ProxyClientSocket::BuildTunnelRequest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix WebSocketStreamCreateTest.HandleErrTunnelConnectionFailed Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_proxy_client_socket.cc ('k') | net/http/proxy_client_socket.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/proxy_client_socket.h
diff --git a/net/http/proxy_client_socket.h b/net/http/proxy_client_socket.h
index f3347c8972e14677a15b1841c5de9dd65389124b..2d6688f72fd84620ef57784504e264d6c52ab3f5 100644
--- a/net/http/proxy_client_socket.h
+++ b/net/http/proxy_client_socket.h
@@ -57,9 +57,9 @@ class NET_EXPORT_PRIVATE ProxyClientSocket : public StreamSocket {
// The HTTP CONNECT method for establishing a tunnel connection is documented
// in draft-luotonen-web-proxy-tunneling-01.txt and RFC 2817, Sections 5.2
// and 5.3.
- static void BuildTunnelRequest(const HttpRequestInfo& request_info,
+ static void BuildTunnelRequest(const HostPortPair& endpoint,
const HttpRequestHeaders& auth_headers,
- const HostPortPair& endpoint,
+ const std::string& user_agent,
std::string* request_line,
HttpRequestHeaders* request_headers);
@@ -71,7 +71,6 @@ class NET_EXPORT_PRIVATE ProxyClientSocket : public StreamSocket {
// Logs (to the log and in a histogram) a blocked CONNECT response.
static void LogBlockedTunnelResponse(int http_response_code,
- const GURL& url,
bool is_https_proxy);
// When a proxy authentication response is received during tunnel
« no previous file with comments | « net/http/http_proxy_client_socket.cc ('k') | net/http/proxy_client_socket.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698