Oilpan: have Console be on the heap by default.

Oilpan: have Console be on the heap by default.

Enable Oilpan for Console and its supplement.

R=haraken
BUG=479467
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194434

[sof, 2015-04-25 07:43:40]

sigbjornf@opera.com changed reviewers:
+ oilpan-reviews@chromium.org

[sof, 2015-04-25 07:43:41]

Please take a look.

[haraken, 2015-04-25 08:07:56]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2015-04-25 08:07:56]

LGTM

https://codereview.chromium.org/1063513007/diff/1/Source/core/frame/Console.h
File Source/core/frame/Console.h (right):

https://codereview.chromium.org/1063513007/diff/1/Source/core/frame/Console.h...
Source/core/frame/Console.h:44: class Console final : public ConsoleBase,
DOMWindowProperty, public HeapSupplementable<Console> {

Nit: Why do we drop public from DOMWindowProperty but have public on
HeapSupplementable?

[sof, 2015-04-25 08:15:31]

https://codereview.chromium.org/1063513007/diff/1/Source/core/frame/Console.h
File Source/core/frame/Console.h (right):

https://codereview.chromium.org/1063513007/diff/1/Source/core/frame/Console.h...
Source/core/frame/Console.h:44: class Console final : public ConsoleBase,
DOMWindowProperty, public HeapSupplementable<Console> {
On 2015/04/25 08:07:56, haraken wrote:
> 
> Nit: Why do we drop public from DOMWindowProperty but have public on
> HeapSupplementable?

I'm just aiming for local consistency, but perhaps I shouldn't bother. i.e., it
is not uncommon to use private inheritance for DOMWindowProperty in modules/, so
thought I'd be consistent throughout. Applying that to supplements could also be
done (I think.)

I'd be just as happy to always use public for these derived interfaces, really.

[haraken, 2015-04-25 08:30:33]

https://codereview.chromium.org/1063513007/diff/1/Source/core/frame/Console.h
File Source/core/frame/Console.h (right):

https://codereview.chromium.org/1063513007/diff/1/Source/core/frame/Console.h...
Source/core/frame/Console.h:44: class Console final : public ConsoleBase,
DOMWindowProperty, public HeapSupplementable<Console> {
On 2015/04/25 08:15:30, sof wrote:
> On 2015/04/25 08:07:56, haraken wrote:
> > 
> > Nit: Why do we drop public from DOMWindowProperty but have public on
> > HeapSupplementable?
> 
> I'm just aiming for local consistency, but perhaps I shouldn't bother. i.e.,
it
> is not uncommon to use private inheritance for DOMWindowProperty in modules/,
so
> thought I'd be consistent throughout. Applying that to supplements could also
be
> done (I think.)
> 
> I'd be just as happy to always use public for these derived interfaces,
really.

Either is fine with me as long as it's consistent :)

(It seems private inheritance is not that common in Blink but I'm not sure.)

[sof, 2015-04-25 08:56:04]

https://codereview.chromium.org/1063513007/diff/1/Source/core/frame/Console.h
File Source/core/frame/Console.h (right):

https://codereview.chromium.org/1063513007/diff/1/Source/core/frame/Console.h...
Source/core/frame/Console.h:44: class Console final : public ConsoleBase,
DOMWindowProperty, public HeapSupplementable<Console> {
On 2015/04/25 08:30:33, haraken wrote:
> On 2015/04/25 08:15:30, sof wrote:
> > On 2015/04/25 08:07:56, haraken wrote:
> > > 
> > > Nit: Why do we drop public from DOMWindowProperty but have public on
> > > HeapSupplementable?
> > 
> > I'm just aiming for local consistency, but perhaps I shouldn't bother. i.e.,
> it
> > is not uncommon to use private inheritance for DOMWindowProperty in
modules/,
> so
> > thought I'd be consistent throughout. Applying that to supplements could
also
> be
> > done (I think.)
> > 
> > I'd be just as happy to always use public for these derived interfaces,
> really.
> 
> Either is fine with me as long as it's consistent :)
> 
> (It seems private inheritance is not that common in Blink but I'm not sure.)

Yes, as Oilpan crosscuts, we end up running into these minor inconsistencies. It
makes sense to me to reconcile those while touching the code.

I will make all DOMWindowProperty deriving classes do it public:ally. Here & in
the Navigator CL.

[sof, 2015-04-25 09:03:45]

The CQ bit was checked by sigbjornf@opera.com

[sof, 2015-04-25 09:03:45]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1063513007/#ps20001
(title: "Console public inherits DOMWindowProperty")

[commit-bot: I haz the power, 2015-04-25 09:04:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1063513007/20001

[commit-bot: I haz the power, 2015-04-25 16:33:08]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194434