Oilpan: have Console be on the heap by default.

Source/core/frame/Console.h

 /*
  * Copyright (C) 2007 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 23 matching lines @@
 #include "platform/Supplementable.h"
 #include "platform/heap/Handle.h"
 #include "wtf/Forward.h"
 #include "wtf/PassRefPtr.h"
 #include "wtf/RefCounted.h"
 
 namespace blink {
 
 class LocalFrame;
 
-class Console final : public ConsoleBase, public DOMWindowProperty, public WillBeHeapSupplementable<Console> {
-    WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(Console);
+class Console final : public ConsoleBase, DOMWindowProperty, public HeapSupplementable<Console> {

[haraken, 2015/04/25 08:07:56]

Nit: Why do we drop public from DOMWindowProperty but have public on
HeapSupplementable?

[sof, 2015/04/25 08:15:30]

I'm just aiming for local consistency, but perhaps I shouldn't bother. i.e., it
is not uncommon to use private inheritance for DOMWindowProperty in modules/, so
thought I'd be consistent throughout. Applying that to supplements could also be
done (I think.)

I'd be just as happy to always use public for these derived interfaces, really.

[haraken, 2015/04/25 08:30:33]

Either is fine with me as long as it's consistent :)

(It seems private inheritance is not that common in Blink but I'm not sure.)

[sof, 2015/04/25 08:56:03]

Yes, as Oilpan crosscuts, we end up running into these minor inconsistencies. It
makes sense to me to reconcile those while touching the code.

I will make all DOMWindowProperty deriving classes do it public:ally. Here & in
the Navigator CL.

+    USING_GARBAGE_COLLECTED_MIXIN(Console);
     DEFINE_WRAPPERTYPEINFO();
 public:
-    static PassRefPtrWillBeRawPtr<Console> create(LocalFrame* frame)
+    static Console* create(LocalFrame* frame)
     {
-        return adoptRefWillBeNoop(new Console(frame));
+        return new Console(frame);
     }
     virtual ~Console();
 
     DECLARE_VIRTUAL_TRACE();
 
 protected:
     virtual ExecutionContext* context() override;
     virtual void reportMessageToConsole(PassRefPtrWillBeRawPtr<ConsoleMessage>) override;
 
 private:
     explicit Console(LocalFrame*);
 };
 
 } // namespace blink
 
 #endif // Console_h