Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 1063453003: browser_tests for sorting columns in Files (Closed)

Created:
5 years, 8 months ago by dhaddock1
Modified:
5 years, 8 months ago
Reviewers:
mtomasz, fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

browser_tests for sorting columns in Files This adds a test to check that clicking the columns headers in Files resorts the columns in the correct order. It checks for ascending and descending. TEST=browser_tests -gtest_filter="*SortColumns/FileManagerBrowserTest*" BUG=None Committed: https://crrev.com/aa89c5bede6aa0b081729ef33899b13a893cb8cf Cr-Commit-Position: refs/heads/master@{#324168}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -0 lines) Patch
M chrome/browser/chromeos/file_manager/file_manager_browsertest.cc View 1 1 chunk +14 lines, -0 lines 0 comments Download
A ui/file_manager/integration_tests/file_manager/sort_columns.js View 1 chunk +186 lines, -0 lines 0 comments Download
M ui/file_manager/integration_tests/file_manager_test_manifest.json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dhaddock1
5 years, 8 months ago (2015-04-07 19:40:56 UTC) #2
mtomasz
lgtm
5 years, 8 months ago (2015-04-08 00:19:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1063453003/20001
5 years, 8 months ago (2015-04-08 00:20:33 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-08 01:21:58 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 01:23:18 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/aa89c5bede6aa0b081729ef33899b13a893cb8cf
Cr-Commit-Position: refs/heads/master@{#324168}

Powered by Google App Engine
This is Rietveld 408576698