Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Unified Diff: chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

Issue 1063453003: browser_tests for sorting columns in Files (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/file_manager/integration_tests/file_manager/sort_columns.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
diff --git a/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc b/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
index 7baadbe023f3f9a3dce85e48d52508af28365070..43a3d0cf3b18a6b5eb6df5e7cbd0382a6ebfeec5 100644
--- a/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
+++ b/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
@@ -1119,6 +1119,20 @@ WRAPPED_INSTANTIATE_TEST_CASE_P(
TestParameter(NOT_IN_GUEST_MODE, "traverseFolderShortcuts"),
TestParameter(NOT_IN_GUEST_MODE, "addRemoveFolderShortcuts")));
+// Slow tests are disabled on debug build. http://crbug.com/327719
+// Fails on official build. http://crbug.com/429294
+// Disabled under MSAN as well. http://crbug.com/468980.
+#if !defined(NDEBUG) || defined(OFFICIAL_BUILD) || defined(MEMORY_SANITIZER)
+#define MAYBE_SortColumns DISABLED_SortColumns
+#else
+#define MAYBE_SortColumns SortColumns
+#endif
+WRAPPED_INSTANTIATE_TEST_CASE_P(
+ MAYBE_SortColumns,
+ FileManagerBrowserTest,
+ ::testing::Values(TestParameter(NOT_IN_GUEST_MODE, "sortColumns"),
+ TestParameter(IN_GUEST_MODE, "sortColumns")));
+
INSTANTIATE_TEST_CASE_P(
TabIndex,
FileManagerBrowserTest,
« no previous file with comments | « no previous file | ui/file_manager/integration_tests/file_manager/sort_columns.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698