Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1063403003: Remove unused InstCounterClass. (Closed)

Created:
5 years, 8 months ago by bungeman-skia
Modified:
5 years, 8 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove unused InstCounterClass. This was added with r4719 (f7943035) to support testing SkTRefArray. With 703d3c70 SkTRefArray and the associated test was removed, but the supporting InstCounterClass was not. Committed: https://skia.googlesource.com/skia/+/693e9930571929cbdc83f1e678b151a768c1bad8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M tests/RefCntTest.cpp View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
bungeman-skia
Some dead code left over from https://codereview.chromium.org/719113004 that I just stumbled upon.
5 years, 8 months ago (2015-04-08 14:51:04 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1063403003/1
5 years, 8 months ago (2015-04-08 14:51:15 UTC) #4
commit-bot: I haz the power
This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-08 15:04:12 UTC) #6
mtklein
lgtm
5 years, 8 months ago (2015-04-08 15:06:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1063403003/1
5 years, 8 months ago (2015-04-08 15:06:19 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 15:06:29 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/693e9930571929cbdc83f1e678b151a768c1bad8

Powered by Google App Engine
This is Rietveld 408576698