Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issue 719113004: Followup: remove unnecessary SkTRefArray (Closed)

Created:
6 years, 1 month ago by mtklein_C
Modified:
6 years, 1 month ago
Reviewers:
mtklein, robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Followup: remove unnecessary SkTRefArray BUG=skia: Committed: https://skia.googlesource.com/skia/+/703d3c7093f1fb8a40a46d465d9dd5ae60a456d5

Patch Set 1 #

Total comments: 2

Patch Set 2 : count #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -225 lines) Patch
M src/core/SkBitmapHeap.h View 2 chunks +0 lines, -9 lines 0 comments Download
M src/core/SkBitmapHeap.cpp View 1 chunk +0 lines, -13 lines 0 comments Download
M src/core/SkPictureData.h View 3 chunks +6 lines, -6 lines 0 comments Download
M src/core/SkPictureData.cpp View 1 8 chunks +18 lines, -25 lines 0 comments Download
M src/core/SkPictureFlat.h View 2 chunks +0 lines, -17 lines 0 comments Download
D src/core/SkTRefArray.h View 1 chunk +0 lines, -112 lines 0 comments Download
M tests/RefCntTest.cpp View 3 chunks +0 lines, -43 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
mtklein
6 years, 1 month ago (2014-11-12 18:39:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/719113004/1
6 years, 1 month ago (2014-11-12 18:39:06 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-11-12 18:39:06 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/887)
6 years, 1 month ago (2014-11-12 18:42:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/719113004/1
6 years, 1 month ago (2014-11-12 18:51:11 UTC) #9
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-11-12 18:51:12 UTC) #10
robertphillips
lgtm + nit https://codereview.chromium.org/719113004/diff/1/src/core/SkPictureData.cpp File src/core/SkPictureData.cpp (right): https://codereview.chromium.org/719113004/diff/1/src/core/SkPictureData.cpp#newcode418 src/core/SkPictureData.cpp:418: const int count = SkToInt(size); pass ...
6 years, 1 month ago (2014-11-12 18:56:14 UTC) #11
mtklein
https://codereview.chromium.org/719113004/diff/1/src/core/SkPictureData.cpp File src/core/SkPictureData.cpp (right): https://codereview.chromium.org/719113004/diff/1/src/core/SkPictureData.cpp#newcode418 src/core/SkPictureData.cpp:418: const int count = SkToInt(size); On 2014/11/12 18:56:14, robertphillips ...
6 years, 1 month ago (2014-11-12 18:58:27 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/719113004/20001
6 years, 1 month ago (2014-11-12 19:00:09 UTC) #14
commit-bot: I haz the power
6 years, 1 month ago (2014-11-12 19:08:25 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/703d3c7093f1fb8a40a46d465d9dd5ae60a456d5

Powered by Google App Engine
This is Rietveld 408576698