Chromium side Implementation to expose aria properties - setsize & posinset

content/browser/accessibility/browser_accessibility_win.cc

Index: content/browser/accessibility/browser_accessibility_win.cc
diff --git a/content/browser/accessibility/browser_accessibility_win.cc b/content/browser/accessibility/browser_accessibility_win.cc
index 1d84b79e211f8e2c25a12a25274f8a3ccdf77a01..84bd345ad96c4b755df9857faaac99592f8f9852 100644
--- a/content/browser/accessibility/browser_accessibility_win.cc
+++ b/content/browser/accessibility/browser_accessibility_win.cc
@@ -3006,10 +3006,19 @@ void BrowserAccessibilityWin::UpdateStep1ComputeWinAttributes() {
   if (GetRole() == ui::AX_ROLE_LIST_BOX_OPTION &&
       GetParent() &&
       GetParent()->GetRole() == ui::AX_ROLE_LIST_BOX) {
-    win_attributes_->ia2_attributes.push_back(
-        L"setsize:" + base::IntToString16(GetParent()->PlatformChildCount()));
-    win_attributes_->ia2_attributes.push_back(
-        L"setsize:" + base::IntToString16(GetIndexInParent() + 1));
+    if (HasIntAttribute(ui::AX_ATTR_SET_SIZE)){
+      IntAttributeToIA2(ui::AX_ATTR_SET_SIZE, "setsize");
+    } else {
+      win_attributes_->ia2_attributes.push_back(
+          L"setsize:" + base::IntToString16(GetParent()->PlatformChildCount()));

[dmazzoni, 2015/04/09 06:31:22]

I think it'd be nicer if this logic was all done in Blink, so we don't have to
check the ARIA set size first and count the number of elements second - for each
platform.

+    }
+
+    if (HasIntAttribute(ui::AX_ATTR_POS_IN_SET)){
+      IntAttributeToIA2(ui::AX_ATTR_POS_IN_SET, "posinset");
+    } else {
+      win_attributes_->ia2_attributes.push_back(
+          L"posinset:" + base::IntToString16(GetIndexInParent() + 1));
+    }
   }
 
   if (ia_role() == ROLE_SYSTEM_CHECKBUTTON ||