Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1063253003: Remove unnessecary includes of ui/compositor/paint_context.h (Closed)

Created:
5 years, 8 months ago by danakj
Modified:
5 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, tdanderson+views_chromium.org, sadrul, Ian Vollick, tfarina, piman+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, noyau+watch_chromium.org, estade+watch_chromium.org, kalyank, danakj+watch_chromium.org, James Su, cc-bugs_chromium.org, rouslan+autofillwatch_chromium.org, enne (OOO), piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnessecary includes of ui/compositor/paint_context.h Now places that just pass the PaintContext through to various *Recorder objects don't need to include this or know what a PaintContext is anymore. TBR=sky BUG=466426 Committed: https://crrev.com/793e0e879ff5edc61b201f49fc6ac61aeb834bcd Cr-Commit-Position: refs/heads/master@{#324258}

Patch Set 1 #

Patch Set 2 : headers: . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M ash/display/cursor_window_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/utility/partial_screenshot_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/boot_splash_screen_chromeos.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/dock/docked_window_layout_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/autofill/autofill_dialog_views.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/infobars/infobar_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/page_action_image_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura/window.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/controls/menu/submenu_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/widget/widget.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
danakj
Just removing headers here, I'll just TBR sky@ for this.
5 years, 8 months ago (2015-04-07 22:32:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1063253003/1
5 years, 8 months ago (2015-04-08 08:06:39 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/55218)
5 years, 8 months ago (2015-04-08 08:11:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1063253003/1
5 years, 8 months ago (2015-04-08 16:31:49 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/40886)
5 years, 8 months ago (2015-04-08 17:06:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1063253003/20001
5 years, 8 months ago (2015-04-08 17:08:59 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-08 18:39:07 UTC) #12
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 18:40:21 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/793e0e879ff5edc61b201f49fc6ac61aeb834bcd
Cr-Commit-Position: refs/heads/master@{#324258}

Powered by Google App Engine
This is Rietveld 408576698