Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 1063083003: Revert of Snap RWHVA and resize the legacy window on Windows whenever the ancestor window's bounds change. (Closed)

Created:
5 years, 8 months ago by Nico
Modified:
5 years, 8 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Snap RWHVA and resize the legacy window on Windows whenever the ancestor window's bounds change. (patchset #12 id:220001 of https://codereview.chromium.org/1062273002/) Reason for revert: Speculative, possibly caused lots of browsert_tests redness on a bot that runs browser_tests with an official build (and a different compiler, but all the redness we fixed on official builds so far were caused by the builds being official, not because of the compiler): http://build.chromium.org/p/chromium.fyi/builders/CrWinClang%20tester/builds/285 (see http://crbug.com/467929) Original issue's description: > Snap RWHVA and resize the legacy window on Windows whenever the ancestor window's bounds change. > > The bookmark bar is hidden through the fast resize code path where in the Renderer is informed about > the actual size minus the bookmar bar before the bookmark bar is hidden. To ensure that the RWHVA is snapped > to pixel boundaries and the legacy window is resized we observe bounds changed events on the parent of the WCVA > window which is the NativeViewHost clipping window. Reason for doing this is the layer for the window hosted by WCVA > verifies if the stored bounds is the same as the one coming in and ignores the change if yes. > > For more context and a general discussion of the reason why this bug happens please visit this link > https://codereview.chromium.org/1009533005/ > > BUG=469857, 468669 > > Committed: https://crrev.com/e6a9b7fff4802ac6796250987be4d52204716392 > Cr-Commit-Position: refs/heads/master@{#324743} TBR=sky@chromium.org,scottmg@chromium.org,cpu@chromium.org,ananta@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=469857, 468669 Committed: https://crrev.com/67bcbf34229acff21e300e630ee871b0a64871b4 Cr-Commit-Position: refs/heads/master@{#324804}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -83 lines) Patch
M content/browser/renderer_host/render_widget_host_view_aura.h View 3 chunks +0 lines, -12 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 4 chunks +0 lines, -71 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Nico
Created Revert of Snap RWHVA and resize the legacy window on Windows whenever the ancestor ...
5 years, 8 months ago (2015-04-13 00:12:20 UTC) #1
Nico
5 years, 8 months ago (2015-04-13 02:58:31 UTC) #2
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1050203004/ by thakis@chromium.org.

The reason for reverting is: Reverting this didn't help, relanding..

Powered by Google App Engine
This is Rietveld 408576698