[Extension API Extern Generation] Fix a few bugs in extern generation

[Extension API Extern Generation] Fix a few bugs in extern generation

Properly handle the case of an "object" (one deliberately left undefined in the
idl/json), and fix an off-by-one error in the comment wrapping.
Add tests for each.

BUG=469920
Committed: https://crrev.com/68411116575f7afcaf5491ed893019da12b649ae
Cr-Commit-Position: refs/heads/master@{#324063}

[Devlin, 2015-04-06 17:05:40]

rdevlin.cronin@chromium.org changed reviewers:
+ dbeam@chromium.org

[Devlin, 2015-04-06 17:05:40]

Nice and short one for you, Dan. :)

[Dan Beam, 2015-04-07 01:54:46]

lgtm w/nit

https://codereview.chromium.org/1062573004/diff/1/tools/json_schema_compiler/...
File tools/json_schema_compiler/js_externs_generator.py (right):

https://codereview.chromium.org/1062573004/diff/1/tools/json_schema_compiler/...
tools/json_schema_compiler/js_externs_generator.py:220: c =
self._GenerateObjectDefinition(js_type.properties)
this is OK i guess but it might be mildly better if we just returned the result
right away from each elif, IMO

[Devlin, 2015-04-07 16:13:27]

https://codereview.chromium.org/1062573004/diff/1/tools/json_schema_compiler/...
File tools/json_schema_compiler/js_externs_generator.py (right):

https://codereview.chromium.org/1062573004/diff/1/tools/json_schema_compiler/...
tools/json_schema_compiler/js_externs_generator.py:220: c =
self._GenerateObjectDefinition(js_type.properties)
On 2015/04/07 01:54:46, Dan Beam wrote:
> this is OK i guess but it might be mildly better if we just returned the
result
> right away from each elif, IMO

Yeah, I guess "return Code().Append('foo')" isn't much worse than
"c.Append('foo')", and it makes it more clear in the cases we just return the
result of another method (like here).  Done.

[Devlin, 2015-04-07 16:13:33]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2015-04-07 16:13:33]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/1062573004/#ps20001
(title: "Dan's")

[commit-bot: I haz the power, 2015-04-07 16:14:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1062573004/20001

[commit-bot: I haz the power, 2015-04-07 17:21:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-07 17:22:12]

Patchset 2 (id:??) landed as
https://crrev.com/68411116575f7afcaf5491ed893019da12b649ae
Cr-Commit-Position: refs/heads/master@{#324063}

[Tyler Breisacher (Chromium), 2015-04-22 19:50:58]

tbreisacher@chromium.org changed reviewers:
+ tbreisacher@chromium.org

[Tyler Breisacher (Chromium), 2015-04-22 19:50:58]

https://codereview.chromium.org/1062573004/diff/20001/tools/json_schema_compi...
File tools/json_schema_compiler/js_externs_generator.py (right):

https://codereview.chromium.org/1062573004/diff/20001/tools/json_schema_compi...
tools/json_schema_compiler/js_externs_generator.py:37: .Append('/**
@fileoverview Externs generated from namespace: %s */' %
Can we add some text here explaining HOW it was generated?

"Externs generated from tools/json_schema_compiler/js_externs_generator.py, from
namespace <namespace>"

or something. Bonus points if it tells you exactly how to run the thing to
regenerate it from the latest IDL.