tools/json_schema_compiler/code.py - Issue 1062573004: [Extension API Extern Generation] Fix a few bugs in extern generation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/json_schema_compiler/code.py

Issue 1062573004: [Extension API Extern Generation] Fix a few bugs in extern generation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Dan's Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/json_schema_compiler/code.py

diff --git a/tools/json_schema_compiler/code.py b/tools/json_schema_compiler/code.py

index 5f0a98a23df5801b3c6c5be2953822941f8f4103..e454e5d444039808553ae73e2f74823f81133fb3 100644

--- a/tools/json_schema_compiler/code.py

+++ b/tools/json_schema_compiler/code.py

@@ -132,7 +132,7 @@ class Code(object):

# First line has the full maximum length.

if not new_line and self._code:

- max_len = self._comment_length - len(self._code[-1].value) - 1

+ max_len = self._comment_length - len(self._code[-1].value)

else:

max_len = (self._comment_length - len(''.join(self._line_prefixes)) -

len(comment_prefix))

« no previous file with comments | « no previous file | tools/json_schema_compiler/code_test.py » ('j') | tools/json_schema_compiler/js_externs_generator.py » ('J')