Issue 106243002: Treat cygwin the same as Windows when selecting the GN binary.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 106243002: Treat cygwin the same as Windows when selecting the GN binary. (Closed)

Created:
7 years ago by brettw

Modified:
7 years ago

Reviewers:
M-A Ruel

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Treat cygwin the same as Windows when selecting the GN binary. R=maruel@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239028

Patch Set 2 : Review comments #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	build/gyp_chromium	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

lgtm https://codereview.chromium.org/106243002/diff/1/build/gyp_chromium File build/gyp_chromium (right): https://codereview.chromium.org/106243002/diff/1/build/gyp_chromium#newcode149 build/gyp_chromium:149: if sys.platform in [ 'win32', 'cygwin' ]: if ...

7 years ago (2013-12-05 14:38:31 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 manually as r239028 (presubmit successful).

Expand Messages | Collapse Messages

Issue 106243002: Treat cygwin the same as Windows when selecting the GN binary. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Review comments #

Messages