Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1033)

Issue 1062413002: Remove unnecessary instrumentation for several jank bugs. (Closed)

Created:
5 years, 8 months ago by Peter Kasting
Modified:
5 years, 8 months ago
CC:
chromium-reviews, asanka, michaeln, cbentzel+watch_chromium.org, mmenke, gavinp+disk_chromium.org, tzik, benjhayden+dwatch_chromium.org, Paweł Hajdan Jr., jam, extensions-reviews_chromium.org, yurys, chromium-apps-reviews_chromium.org, nhiroki, darin-cc_chromium.org, jkarlin+watch_chromium.org, devtools-reviews_chromium.org, piman+watch_chromium.org, aandrey+blink_chromium.org, kinuko+fileapi, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary instrumentation for several jank bugs. BUG=437890, 436671, 455423, 424386, 436634, 422516 TEST=none TBR=jochen,cbentzel,jyasskin Committed: https://crrev.com/379234c28f3856045a67af657296d6911156bbff Cr-Commit-Position: refs/heads/master@{#324185}

Patch Set 1 #

Patch Set 2 : Formatting #

Patch Set 3 : Compile fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -1206 lines) Patch
M chrome/browser/devtools/device/port_forwarding_controller.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/download/download_resource_throttle.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/net/chrome_url_request_context_getter.cc View 7 chunks +0 lines, -29 lines 0 comments Download
M chrome/browser/net/predictor.cc View 9 chunks +16 lines, -75 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_io_data.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.cc View 8 chunks +16 lines, -56 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 6 chunks +0 lines, -25 lines 0 comments Download
M chrome/browser/task_manager/browser_process_resource_provider.cc View 3 chunks +12 lines, -18 lines 0 comments Download
M chrome/browser/task_manager/task_manager.cc View 1 chunk +0 lines, -47 lines 0 comments Download
M components/domain_reliability/monitor.cc View 3 chunks +1 line, -11 lines 0 comments Download
M components/nacl/browser/pnacl_translation_cache.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M content/browser/appcache/appcache_response.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/appcache/appcache_update_job.cc View 3 chunks +0 lines, -11 lines 0 comments Download
M content/browser/cache_storage/cache_storage_cache.cc View 1 2 chunks +2 lines, -10 lines 0 comments Download
M content/browser/fileapi/mock_url_request_delegate.cc View 3 chunks +0 lines, -11 lines 0 comments Download
M content/browser/gpu/shader_disk_cache.cc View 6 chunks +0 lines, -26 lines 0 comments Download
M content/browser/loader/power_save_block_resource_throttle.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_dispatcher_host.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_lookup_request.h View 2 chunks +0 lines, -6 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M extensions/browser/api/dns/dns_api.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M extensions/browser/api/socket/socket_api.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M net/base/net_util_win.cc View 1 2 3 chunks +11 lines, -25 lines 0 comments Download
M net/base/network_change_notifier_win.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M net/cert/x509_certificate.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/blockfile/in_flight_backend_io.cc View 13 chunks +18 lines, -97 lines 0 comments Download
M net/disk_cache/blockfile/in_flight_io.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M net/disk_cache/cache_creator.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M net/dns/host_resolver_impl.cc View 7 chunks +0 lines, -31 lines 0 comments Download
M net/dns/single_request_host_resolver.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M net/ftp/ftp_network_transaction.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M net/http/disk_based_cert_cache.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M net/http/disk_cache_based_quic_server_info.cc View 12 chunks +0 lines, -66 lines 0 comments Download
M net/http/http_auth_handler_negotiate.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M net/http/http_cache.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M net/http/http_cache_transaction.cc View 44 chunks +10 lines, -227 lines 0 comments Download
M net/http/partial_data.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M net/proxy/proxy_resolver_v8_tracing.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M net/proxy/proxy_script_decider.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M net/quic/crypto/quic_crypto_client_config.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M net/quic/quic_crypto_client_stream.cc View 3 chunks +0 lines, -15 lines 0 comments Download
M net/socket/client_socket_pool_base.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M net/socket/socks_client_socket.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M net/socket/ssl_client_socket_nss.cc View 10 chunks +0 lines, -51 lines 0 comments Download
M net/socket/ssl_client_socket_openssl.cc View 9 chunks +5 lines, -64 lines 0 comments Download
M net/socket/ssl_client_socket_pool.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M net/socket/ssl_session_cache_openssl.cc View 9 chunks +0 lines, -41 lines 0 comments Download
M net/socket/tcp_client_socket.cc View 1 2 3 chunks +21 lines, -32 lines 0 comments Download
M net/socket/tcp_socket_win.cc View 6 chunks +11 lines, -28 lines 0 comments Download
M net/socket/transport_client_socket_pool.h View 2 chunks +0 lines, -12 lines 0 comments Download
M net/socket/transport_client_socket_pool.cc View 6 chunks +2 lines, -32 lines 0 comments Download
M net/socket/websocket_transport_client_socket_pool.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M net/ssl/openssl_platform_key_win.cc View 3 chunks +0 lines, -9 lines 0 comments Download
M net/tools/dump_cache/simple_cache_dumper.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M net/url_request/view_cache_helper.cc View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Peter Kasting
TBR to: jochen: chrome/, components/, content/ OWNERS jyasskin: extensions/ OWNERS cbentzel: net/ OWNERS
5 years, 8 months ago (2015-04-08 01:21:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1062413002/20001
5 years, 8 months ago (2015-04-08 01:22:28 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/55150)
5 years, 8 months ago (2015-04-08 01:32:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1062413002/40001
5 years, 8 months ago (2015-04-08 02:13:44 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-08 04:42:25 UTC) #9
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/379234c28f3856045a67af657296d6911156bbff Cr-Commit-Position: refs/heads/master@{#324185}
5 years, 8 months ago (2015-04-08 04:43:08 UTC) #10
Jeffrey Yasskin
5 years, 8 months ago (2015-04-08 05:39:17 UTC) #11
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698