Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Side by Side Diff: components/nacl/browser/pnacl_translation_cache.cc

Issue 1062413002: Remove unnecessary instrumentation for several jank bugs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Compile fixes Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/domain_reliability/monitor.cc ('k') | content/browser/appcache/appcache_response.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/nacl/browser/pnacl_translation_cache.h" 5 #include "components/nacl/browser/pnacl_translation_cache.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/callback.h" 9 #include "base/callback.h"
10 #include "base/files/file_path.h" 10 #include "base/files/file_path.h"
11 #include "base/logging.h" 11 #include "base/logging.h"
12 #include "base/profiler/scoped_tracker.h"
13 #include "base/strings/string_number_conversions.h" 12 #include "base/strings/string_number_conversions.h"
14 #include "base/threading/thread_checker.h" 13 #include "base/threading/thread_checker.h"
15 #include "components/nacl/common/pnacl_types.h" 14 #include "components/nacl/common/pnacl_types.h"
16 #include "content/public/browser/browser_thread.h" 15 #include "content/public/browser/browser_thread.h"
17 #include "net/base/io_buffer.h" 16 #include "net/base/io_buffer.h"
18 #include "net/base/net_errors.h" 17 #include "net/base/net_errors.h"
19 #include "net/disk_cache/disk_cache.h" 18 #include "net/disk_cache/disk_cache.h"
20 19
21 using base::IntToString; 20 using base::IntToString;
22 using content::BrowserThread; 21 using content::BrowserThread;
(...skipping 211 matching lines...) Expand 10 before | Expand all | Expand 10 after
234 } else { 233 } else {
235 if (!write_callback_.is_null()) { 234 if (!write_callback_.is_null()) {
236 BrowserThread::PostTask( 235 BrowserThread::PostTask(
237 BrowserThread::IO, FROM_HERE, base::Bind(write_callback_, rv)); 236 BrowserThread::IO, FROM_HERE, base::Bind(write_callback_, rv));
238 } 237 }
239 } 238 }
240 cache_->OpComplete(this); 239 cache_->OpComplete(this);
241 } 240 }
242 241
243 void PnaclTranslationCacheEntry::DispatchNext(int rv) { 242 void PnaclTranslationCacheEntry::DispatchNext(int rv) {
244 // TODO(vadimt): Remove ScopedTracker below once crbug.com/422516 is fixed.
245 tracked_objects::ScopedTracker tracking_profile(
246 FROM_HERE_WITH_EXPLICIT_FUNCTION(
247 "422516 PnaclTranslationCacheEntry::DispatchNext"));
248
249 DCHECK(thread_checker_.CalledOnValidThread()); 243 DCHECK(thread_checker_.CalledOnValidThread());
250 if (!cache_) 244 if (!cache_)
251 return; 245 return;
252 246
253 switch (step_) { 247 switch (step_) {
254 case UNINITIALIZED: 248 case UNINITIALIZED:
255 case FINISHED: 249 case FINISHED:
256 LOG(ERROR) << "DispatchNext called uninitialized"; 250 LOG(ERROR) << "DispatchNext called uninitialized";
257 break; 251 break;
258 252
(...skipping 185 matching lines...) Expand 10 before | Expand all | Expand 10 after
444 } 438 }
445 439
446 int PnaclTranslationCache::DoomEntriesBetween( 440 int PnaclTranslationCache::DoomEntriesBetween(
447 base::Time initial, 441 base::Time initial,
448 base::Time end, 442 base::Time end,
449 const CompletionCallback& callback) { 443 const CompletionCallback& callback) {
450 return disk_cache_->DoomEntriesBetween(initial, end, callback); 444 return disk_cache_->DoomEntriesBetween(initial, end, callback);
451 } 445 }
452 446
453 } // namespace pnacl 447 } // namespace pnacl
OLDNEW
« no previous file with comments | « components/domain_reliability/monitor.cc ('k') | content/browser/appcache/appcache_response.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698