Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1062333002: Don't enable @viewport support in inspector emulation. (Closed)

Created:
5 years, 8 months ago by rune
Modified:
5 years, 8 months ago
CC:
aandrey+blink_chromium.org, apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, yurys+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Don't enable @viewport support in inspector emulation. Author support for @viewport is not enabled on Android and should not be enabled in mobile emulation mode in the inspector. The idea is that if @viewport support is enabled by default, it will be enabled on all platforms, and there will be no need for a switch in the emulation code of the inspector. R=dgozman@chromium.org BUG=467204 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193365

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M Source/web/DevToolsEmulator.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/DevToolsEmulator.cpp View 3 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
rune
The only way of testing this, as @viewport is "experimental" and enabled for testing, is ...
5 years, 8 months ago (2015-04-07 22:25:28 UTC) #1
dgozman
Hmm... When I added this originally, I was pretty sure that css viewport was enabled ...
5 years, 8 months ago (2015-04-08 05:10:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1062333002/1
5 years, 8 months ago (2015-04-08 08:10:58 UTC) #4
rune
aelias for Source/web
5 years, 8 months ago (2015-04-08 08:18:13 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/30753)
5 years, 8 months ago (2015-04-08 08:35:08 UTC) #8
aelias_OOO_until_Jul13
lgtm
5 years, 8 months ago (2015-04-08 13:10:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1062333002/1
5 years, 8 months ago (2015-04-08 15:25:32 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 15:45:51 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193365

Powered by Google App Engine
This is Rietveld 408576698