Fix docked browser window sometimes appears onscreen after restart

Fix docked browser window sometimes appears onscreen after restart

(Continuing from original cl https://codereview.chromium.org/1055893003 .)

Change IsMaximized() to return false if the window is in the dock, and
a unit test to make sure this is always the case. It turns out
-isZoomed can sometimes return YES for a docked window, which
sometimes results in the window becoming undocked on the next restart.
Please read the long entry in the bug report for a complete explanation
of how the change fixes the problem.

BUG=452976
Committed: https://crrev.com/900997341ee5c7076b345ce35c6644226a507f6d
Cr-Commit-Position: refs/heads/master@{#324079}

[shrike, 2015-04-07 17:54:44]

shrike@chromium.org changed reviewers:
+ avi@chromium.org

[shrike, 2015-04-07 18:03:18]

Hello Avi,

The 10.6 bot didn't like the previous version of my unit test - at the end the
test calls BrowserWindowCocoa::Restore() which should have called [window
deminiaturize:], but when checking the browser window's state the window still
reported that it was miniaturized. I don't know if this is a timing issue, or if
in 10.6 the window will report that it's miniaturized until you receive a
NSWindowDidDeminiaturizeNotification, or a bug in the Appkit, but in any case
checking the window's state after calling BrowserWindowCocoa::Restore() is not
relevant to the unit test, so I have removed those lines in the new version of
the test.

PTAL

[Avi (use Gerrit), 2015-04-07 18:12:54]

S LGTM

[shrike, 2015-04-07 18:47:39]

The CQ bit was checked by shrike@chromium.org

[commit-bot: I haz the power, 2015-04-07 18:48:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1062053002/20001

[commit-bot: I haz the power, 2015-04-07 18:55:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-07 18:56:38]

Patchset 2 (id:??) landed as
https://crrev.com/900997341ee5c7076b345ce35c6644226a507f6d
Cr-Commit-Position: refs/heads/master@{#324079}