Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Issue 1055893003: Fix docked browser window sometimes appears onscreen after restart (Closed)

Created:
5 years, 8 months ago by shrike
Modified:
5 years, 8 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change IsMaximized() to return false if the window is in the dock, and a unit test to make sure this is always the case. It turns out -isZoomed can sometimes return YES for a docked window, which sometimes results in the window becoming undocked on the next restart. Please read the long entry in the bug report for a complete explanation of how the change fixes the problem. BUG=452976 Committed: https://crrev.com/de8b6d82a032a4bde620e43e6c580850871d59d8 Cr-Commit-Position: refs/heads/master@{#323928}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm View 1 chunk +18 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
shrike
PTAL
5 years, 8 months ago (2015-04-06 18:06:11 UTC) #2
Avi (use Gerrit)
Oh, that looked like fun! LGTM
5 years, 8 months ago (2015-04-06 18:57:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1055893003/1
5 years, 8 months ago (2015-04-06 18:59:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-06 19:03:53 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/de8b6d82a032a4bde620e43e6c580850871d59d8 Cr-Commit-Position: refs/heads/master@{#323928}
5 years, 8 months ago (2015-04-06 19:04:47 UTC) #7
Sergey Ulanov
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1061103003/ by sergeyu@chromium.org. ...
5 years, 8 months ago (2015-04-06 22:18:26 UTC) #8
shrike
5 years, 8 months ago (2015-04-06 23:47:33 UTC) #9
Message was sent while issue was closed.
On 2015/04/06 22:18:26, Sergey Ulanov wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/1061103003/ by mailto:sergeyu@chromium.org.
> 
> The reason for reverting is: Broke BrowserWindowCocoaTest.TestMinimizeState on
> 10.6:
> https://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests/builds/762.

Continuing to https://codereview.chromium.org/1062053002/

Powered by Google App Engine
This is Rietveld 408576698