[Sync] Sync the chrome://history page

[Sync] Sync the chrome://history page

Whitelist the chrome history page so that it can trigger starting up the sync
engine. It gets special treatment since it's where the other devices UI lives.

BUG=476678
Committed: https://crrev.com/9586f7bf8845cf76b8d436004be04d6d47cefcf6
Cr-Commit-Position: refs/heads/master@{#325489}

[Nicolas Zea, 2015-04-14 18:49:39]

zea@chromium.org changed reviewers:
+ stanisc@chromium.org

[Nicolas Zea, 2015-04-14 18:49:40]

PTAL

[stanisc, 2015-04-14 22:42:40]

https://codereview.chromium.org/1062013003/diff/20001/chrome/browser/sync/ses...
File chrome/browser/sync/sessions/sessions_util.cc (right):

https://codereview.chromium.org/1062013003/diff/20001/chrome/browser/sync/ses...
chrome/browser/sync/sessions/sessions_util.cc:43: // The history page is treated
specially as we want it to trigger syncable
Wouldn't there be a race condition between the page loading and Sync backend
initializing? How does this guarantee DeviceInfo to be initialized by the time
the page loads? Would history page refresh on its own once DeviceInfo becomes
available?

https://codereview.chromium.org/1062013003/diff/20001/chrome/browser/sync/ses...
chrome/browser/sync/sessions/sessions_util.cc:45: found_valid_url = true;
Perhaps break the loop (here and above) once the valid url is found.

[Nicolas Zea, 2015-04-16 17:30:30]

https://codereview.chromium.org/1062013003/diff/20001/chrome/browser/sync/ses...
File chrome/browser/sync/sessions/sessions_util.cc (right):

https://codereview.chromium.org/1062013003/diff/20001/chrome/browser/sync/ses...
chrome/browser/sync/sessions/sessions_util.cc:43: // The history page is treated
specially as we want it to trigger syncable
On 2015/04/14 22:42:40, stanisc wrote:
> Wouldn't there be a race condition between the page loading and Sync backend
> initializing? How does this guarantee DeviceInfo to be initialized by the time
> the page loads? Would history page refresh on its own once DeviceInfo becomes
> available?

Yes, but that's fine. Once we do model association we'll capture whatever the
contents of the page is. And yes, the history page will refresh on its own once
the synced tab state is available (it doesn't actually depend on device info).

https://codereview.chromium.org/1062013003/diff/20001/chrome/browser/sync/ses...
chrome/browser/sync/sessions/sessions_util.cc:45: found_valid_url = true;
On 2015/04/14 22:42:40, stanisc wrote:
> Perhaps break the loop (here and above) once the valid url is found.

We actually deliberately keep looping to ensure that all the entries in the
navigation stack are valid (and return false early if not, in line 35).

[stanisc, 2015-04-16 18:03:24]

lgtm

[Nicolas Zea, 2015-04-16 18:04:45]

The CQ bit was checked by zea@chromium.org

[commit-bot: I haz the power, 2015-04-16 18:06:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1062013003/20001

[commit-bot: I haz the power, 2015-04-16 19:09:48]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-16 19:11:35]

Patchset 2 (id:??) landed as
https://crrev.com/9586f7bf8845cf76b8d436004be04d6d47cefcf6
Cr-Commit-Position: refs/heads/master@{#325489}