[Sync] Sync the chrome://history page

chrome/browser/sync/sessions/sessions_util.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/sessions/sessions_util.h"
 
 #include "chrome/browser/sync/glue/synced_tab_delegate.h"
 #include "chrome/browser/sync/glue/synced_window_delegate.h"
 #include "chrome/common/url_constants.h"
 #include "content/public/browser/navigation_entry.h"
@@ skipping 21 matching lines @@
     const content::NavigationEntry* entry = (i == pending_index) ?
        tab.GetPendingEntry() : tab.GetEntryAtIndex(i);
     if (!entry)
       return false;
     const GURL& virtual_url = entry->GetVirtualURL();
     if (virtual_url.is_valid() &&
         !virtual_url.SchemeIs(content::kChromeUIScheme) &&
         !virtual_url.SchemeIs(chrome::kChromeNativeScheme) &&
         !virtual_url.SchemeIsFile()) {
       found_valid_url = true;
+    } else if (virtual_url == GURL(chrome::kChromeUIHistoryURL)) {
+      // The history page is treated specially as we want it to trigger syncable

[stanisc, 2015/04/14 22:42:40]

Wouldn't there be a race condition between the page loading and Sync backend
initializing? How does this guarantee DeviceInfo to be initialized by the time
the page loads? Would history page refresh on its own once DeviceInfo becomes
available?

[Nicolas Zea, 2015/04/16 17:30:30]

Yes, but that's fine. Once we do model association we'll capture whatever the
contents of the page is. And yes, the history page will refresh on its own once
the synced tab state is available (it doesn't actually depend on device info).

+      // events for UI purposes.
+      found_valid_url = true;

[stanisc, 2015/04/14 22:42:40]

Perhaps break the loop (here and above) once the valid url is found.

[Nicolas Zea, 2015/04/16 17:30:29]

We actually deliberately keep looping to ensure that all the entries in the
navigation stack are valid (and return false early if not, in line 35).

     }
   }
   return found_valid_url;
 }
 
 }  // namespace sessions_util
 
 }  // namespace browser_sync