Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 1062003003: ash: Access the Canvas for painting through PaintRecorder. (Closed)

Created:
5 years, 8 months ago by danakj
Modified:
5 years, 8 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul, enne (OOO), piman, sky
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ash: Access the Canvas for painting through PaintRecorder. The PaintContext will not be backed by a Canvas in the future, so do not grab the canvas from it directly. Instead use a PaintRecorder. R=oshima BUG=466426 Committed: https://crrev.com/a59147554aaa82da73512da5f9d61e9265d54bc0 Cr-Commit-Position: refs/heads/master@{#324071}

Patch Set 1 #

Patch Set 2 : ash-recorder: . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -28 lines) Patch
M ash/utility/partial_screenshot_controller.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M ash/wm/boot_splash_screen_chromeos.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ash/wm/dock/docked_window_layout_manager.cc View 1 2 chunks +12 lines, -24 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
danakj
5 years, 8 months ago (2015-04-07 00:20:53 UTC) #1
oshima
lgtm
5 years, 8 months ago (2015-04-07 16:54:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1062003003/20001
5 years, 8 months ago (2015-04-07 18:06:29 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-07 18:10:47 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 18:11:43 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a59147554aaa82da73512da5f9d61e9265d54bc0
Cr-Commit-Position: refs/heads/master@{#324071}

Powered by Google App Engine
This is Rietveld 408576698