Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 1061953002: Work on Windows GN component build. (Closed)

Created:
5 years, 8 months ago by brettw
Modified:
5 years, 8 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Work on Windows GN component build. This makes ppapi_shared link. This required many changes to gpu to match the structure of GYP in both component and non-component modes. BUG=470212 CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg Reland of https://codereview.chromium.org/1053203003/ Committed: https://crrev.com/542f7537cf6f2d0a01be2893a859aaf629527fdd Cr-Commit-Position: refs/heads/master@{#323966}

Patch Set 1 #

Patch Set 2 : fix #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -49 lines) Patch
M components/nacl/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/BUILD.gn View 3 chunks +6 lines, -3 lines 0 comments Download
M gpu/BUILD.gn View 1 chunk +5 lines, -5 lines 0 comments Download
M gpu/blink/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/client/BUILD.gn View 3 chunks +35 lines, -19 lines 0 comments Download
M gpu/command_buffer/common/BUILD.gn View 1 chunk +19 lines, -1 line 0 comments Download
M gpu/command_buffer/service/BUILD.gn View 3 chunks +16 lines, -6 lines 0 comments Download
M gpu/config/BUILD.gn View 2 chunks +16 lines, -2 lines 0 comments Download
M gpu/ipc/BUILD.gn View 2 chunks +16 lines, -2 lines 0 comments Download
M media/base/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/proxy/BUILD.gn View 2 chunks +14 lines, -2 lines 0 comments Download
M ppapi/shared_impl/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/thunk/BUILD.gn View 2 chunks +13 lines, -1 line 0 comments Download
M ui/gl/BUILD.gn View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ui/surface/BUILD.gn View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
brettw
Hi Dirk, Not sure why the trybots didn't catch this problem: http://build.chromium.org/p/chromium.linux/builders/Linux%20GN/builds/26255/steps/compile/logs/stdio Patch 1 is ...
5 years, 8 months ago (2015-04-06 20:53:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1061953002/20001
5 years, 8 months ago (2015-04-06 20:53:53 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gn_dbg on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_dbg/builds/286) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 8 months ago (2015-04-06 21:01:19 UTC) #6
Dirk Pranke
https://codereview.chromium.org/1061953002/diff/20001/ui/gl/BUILD.gn File ui/gl/BUILD.gn (right): https://codereview.chromium.org/1061953002/diff/20001/ui/gl/BUILD.gn#newcode114 ui/gl/BUILD.gn:114: public_configs += [ "//third_party/khronos:khronos_headers" ] lgtm assuming you change ...
5 years, 8 months ago (2015-04-06 21:07:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1061953002/40001
5 years, 8 months ago (2015-04-06 21:10:00 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-06 22:36:10 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-04-06 22:36:58 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/542f7537cf6f2d0a01be2893a859aaf629527fdd
Cr-Commit-Position: refs/heads/master@{#323966}

Powered by Google App Engine
This is Rietveld 408576698